Skip to content

Commit

Permalink
Add TODO to remove strip for linux binary
Browse files Browse the repository at this point in the history
Change-Id: I9ae679b495b55297028bd8b57099116fd2ed5f5e
no-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2854536
Auto-Submit: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#876806}
  • Loading branch information
k7z45 authored and Chromium LUCI CQ committed Apr 27, 2021
1 parent 5d9718d commit b137b59
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions chrome/test/chromedriver/support/release/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ unzip $src/chromedriver_mac64.zip
unzip $src/chromedriver_mac64_m1.zip -d chromedriver_mac64_m1/
unzip $src/chromedriver_win32.zip

# TODO: Remove this line after verifying strip has no effect
strip -p chromedriver_linux64/chromedriver

zip -j $tgt/chromedriver_linux64.zip chromedriver_linux64/chromedriver
Expand Down

0 comments on commit b137b59

Please sign in to comment.