Skip to content

Commit

Permalink
Switch to simpler base::WriteFile() variants (62/N)
Browse files Browse the repository at this point in the history
This CL is part of a batch of CLs to replace the use of the less
friendly base::WriteFile call with simpler variants, which are easier to
read, and less prone to mistakes.

Changes in this particular CL address files under the path
/chromecast/crash.

This CL was uploaded by git cl split.

R=dnicoara@chromium.org

AX-Relnotes: n/a.
Bug: 418837
Change-Id: I916b1ada29bc2e54f2f39e6177c63f6bb15c2077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288686
Auto-Submit: Claudio DeSouza <cdesouza@igalia.com>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1111031}
  • Loading branch information
cdesouza-chromium authored and Chromium LUCI CQ committed Feb 28, 2023
1 parent 3bd809f commit 9fb61b5
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions chromecast/crash/linux/dummy_minidump_generator_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ TEST(DummyMinidumpGeneratorTest, GenerateSucceedsWithSmallSource) {
// Create a fake minidump file.
ScopedTempFile fake_minidump;
const std::string data("Test contents of the minidump file.\n");
ASSERT_EQ(static_cast<int>(data.size()),
base::WriteFile(fake_minidump.path(), data.c_str(), data.size()));
ASSERT_TRUE(base::WriteFile(fake_minidump.path(), data));

DummyMinidumpGenerator generator(fake_minidump.path().value());
base::FilePath new_minidump = minidump_dir.GetPath().Append("minidump.dmp");
Expand All @@ -61,8 +60,7 @@ TEST(DummyMinidumpGeneratorTest, GenerateSucceedsWithLargeSource) {
const std::string data = base::RandBytesAsString(str_len);

// Write the string to the file.
ASSERT_EQ(static_cast<int>(data.size()),
base::WriteFile(fake_minidump.path(), data.c_str(), data.size()));
ASSERT_TRUE(base::WriteFile(fake_minidump.path(), data));

base::FilePath new_minidump = minidump_dir.GetPath().Append("minidump.dmp");
DummyMinidumpGenerator generator(fake_minidump.path().value());
Expand Down

0 comments on commit 9fb61b5

Please sign in to comment.