Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Add gtest absl deps to the absl component."
This is a reland of 3a2a481 This CL moves the declare_arg of gtest_enable_absl_printers to //build_overrides (which is already imported by googletest and abseil-cpp BUILD.gn files) in order to avoid the "undefined identifier" error when build_with_chromium=true. Original change's description: > Add gtest absl deps to the absl component. > > This CL conditionally adds absl/debugging deps to the absl component > if build_with_chromium=false. This will allow downstream projects to > use gtest with absl (for pretty printers and matchers) but it will > remove these dependencies in Chromium to avoid to add static > initializers. > > When static initializers will be removed, the dependency will not be > conditional so Chromium will also be able to set > 'gtest_enable_absl_printers=true'. > > Bug: 1046390 > Change-Id: Ifffea81ba8f7a9412bebc3798e8f79eaff2777d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262972 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782889} Bug: 1046390 Change-Id: Id977a6a868b389b4d9924eb3af5a5f5cd0c3f4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270298 Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783087}
- Loading branch information