Skip to content

Commit

Permalink
[Chromecast] Create chromecast-linux-builder-perf to monitor cast binary
Browse files Browse the repository at this point in the history
sizes.

Bug: internal b/171587889
Change-Id: Ie1e368f17d26118b0458da3b2f3cb4ac48c27c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783146
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#865929}
  • Loading branch information
Junbo Ke authored and Chromium LUCI CQ committed Mar 24, 2021
1 parent ba4974e commit 8ac265f
Show file tree
Hide file tree
Showing 7 changed files with 76 additions and 0 deletions.
33 changes: 33 additions & 0 deletions testing/buildbot/chromium.perf.json
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,39 @@
}
]
},
"chromecast-linux-builder-perf": {
"additional_compile_targets": [
"cast_shell"
],
"isolated_scripts": [
{
"args": [],
"isolate_name": "resource_sizes_chromecast",
"merge": {
"script": "//tools/perf/process_perf_results.py"
},
"name": "resource_sizes_chromecast",
"override_compile_targets": [
"resource_sizes_chromecast"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"cpu": "x86-64",
"os": "Ubuntu-16.04",
"pool": "chrome.tests"
}
],
"expiration": 7200,
"hard_timeout": 21600,
"ignore_task_failure": false,
"io_timeout": 21600,
"service_account": "chrome-tester@chops-service-accounts.iam.gserviceaccount.com"
}
}
]
},
"chromeos-amd64-generic-lacros-builder-perf": {
"additional_compile_targets": [
"chrome"
Expand Down
4 changes: 4 additions & 0 deletions testing/buildbot/gn_isolate_map.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1530,6 +1530,10 @@
"label": "//chrome/android:resource_sizes_chrome_modern_public_minimal_apks",
"type": "generated_script",
},
"resource_sizes_chromecast": {
"label": "//chromecast:resource_sizes_chromecast",
"type": "generated_script",
},
"resource_sizes_cronet_sample_apk": {
"label": "//components/cronet/android:resource_sizes_cronet_sample_apk",
"type": "generated_script",
Expand Down
1 change: 1 addition & 0 deletions tools/mb/mb_config.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,7 @@
'Android arm64 Builder Perf': 'official_goma_minimal_symbols_android_arm64',
'android_arm64-builder-perf': 'official_goma_minimal_symbols_android_arm64',
'android-builder-perf': 'official_goma_minimal_symbols_android',
'chromecast-linux-builder-perf': 'cast_binary_size',
'chromeos-amd64-generic-lacros-builder-perf': 'chromeos_amd64-generic_lacros_official',
'linux-builder-perf': 'official_goma_linux_perf',
'linux-builder-perf-rel': 'official_goma_linux_perf',
Expand Down
8 changes: 8 additions & 0 deletions tools/mb/mb_config_expectations/chromium.perf.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@
"use_goma": true
}
},
"chromecast-linux-builder-perf": {
"gn_args": {
"is_chromecast": true,
"is_official_build": true,
"symbol_level": 1,
"use_goma": true
}
},
"chromeos-amd64-generic-lacros-builder-perf": {
"args_file": "//build/args/chromeos/amd64-generic.gni",
"gn_args": {
Expand Down
1 change: 1 addition & 0 deletions tools/perf/benchmark.csv
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ rendering.desktop,"behdadb@chromium.org, jonross@chromium.org, sadrul@chromium.o
rendering.mobile,"behdadb@chromium.org, jonross@chromium.org, sadrul@chromium.org",Internals>GPU>Metrics,https://bit.ly/rendering-benchmarks,"backdrop_filter,fastpath,gpu_rasterization,image_decoding,key_hit_test,key_idle_power,key_noop,key_silk,maps,motionmark,pathological_mobile_sites,polymer,representative_mac_desktop,representative_mobile,representative_win_desktop,required_webgl,simple_canvas,simple_mobile_sites,throughput_test,top_real_world_desktop,top_real_world_mobile,tough_animation,tough_canvas,tough_compositor,tough_filters,tough_image_decode,tough_path_rendering,tough_pinch_zoom_mobile,tough_scheduling,tough_scrolling,tough_texture_upload,tough_webgl,use_fake_camera_device"
resource_sizes_chrome_modern_minimal_apks,"agrieve@chromium.org, jbudorick@chromium.org",Build,https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py,
resource_sizes_chrome_modern_public_minimal_apks,"agrieve@chromium.org, jbudorick@chromium.org",Build,https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py,
resource_sizes_chromecast,"juke@chromium.org, eliribble@chromium.org",Chromecast,https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py,
resource_sizes_lacros_chrome,"erikchen@chromium.org, huangs@chromium.org",OS>LaCrOS,https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py,
resource_sizes_monochrome_minimal_apks,"agrieve@chromium.org, jbudorick@chromium.org",Build,https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py,
resource_sizes_monochrome_public_minimal_apks,"agrieve@chromium.org, jbudorick@chromium.org",Build,https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py,
Expand Down
28 changes: 28 additions & 0 deletions tools/perf/core/perf_data_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,23 @@ class TEST_TYPES(object):
'platform': 'linux',
'perf_processor': True,
},
'chromecast-linux-builder-perf': {
'additional_compile_targets': ['cast_shell'],
'tests': [
{
'name': 'resource_sizes_chromecast',
'isolate': 'resource_sizes_chromecast',
'type': TEST_TYPES.GENERIC,
},
],
'dimension': {
'cpu': 'x86-64',
'os': 'Ubuntu-16.04',
'pool': 'chrome.tests',
},
'perf_trigger':
False,
},
'chromeos-amd64-generic-lacros-builder-perf': {
'additional_compile_targets': ['chrome'],
'tests': [
Expand Down Expand Up @@ -1092,6 +1109,17 @@ def tags(self):
),
})

OTHER_BENCHMARKS.update({
'resource_sizes_chromecast':
BenchmarkMetadata(
emails='juke@chromium.org, eliribble@chromium.org',
component='Chromecast',
documentation_url=(
'https://chromium.googlesource.com/chromium/'
'src/+/HEAD/tools/binary_size/README.md#resource_sizes_py'),
),
})

OTHER_BENCHMARKS.update({
'resource_sizes_lacros_chrome':
BenchmarkMetadata(
Expand Down
1 change: 1 addition & 0 deletions tools/perf/core/perf_json_config_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
'android-builder-perf': {'chrome.tests'},
'android_arm64-builder-perf': {'chrome.tests'},
'android-pixel4a_power-perf': {'chrome.tests.pinpoint'},
'chromecast-linux-builder-perf': {'chrome.tests'},
'chromeos-kevin-perf-fyi': {'chrome.tests'},
'chromeos-amd64-generic-lacros-builder-perf': {'chrome.tests'},
'fuchsia-perf-fyi': {'chrome.tests'},
Expand Down

0 comments on commit 8ac265f

Please sign in to comment.