Skip to content

Commit

Permalink
Remove Fuchsia SDK's 'launchpad' package definition.
Browse files Browse the repository at this point in the history
The 'launchpad' package has been removed from the Fuchsia SDK, with its
functionality replaced by fdio_spawn(). The lingering definition will
e.g. block Chromium dependency rolls into V8, so we need to remove it
ASAP.

TBR: jam
Bug: 848028
Change-Id: Iac4ed84b65e9c077c9fe97d75c636f19ff597e74
Reviewed-on: https://chromium-review.googlesource.com/1098675
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567336}
  • Loading branch information
Wez authored and Commit Bot committed Jun 14, 2018
1 parent 0d6d080 commit 808ccb5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
2 changes: 1 addition & 1 deletion content/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ source_set("common") {
"sandbox_policy_fuchsia.h",
]

deps += [ "//third_party/fuchsia-sdk:launchpad" ]
deps += [ "//third_party/fuchsia-sdk:fdio" ]
}
}

Expand Down
2 changes: 1 addition & 1 deletion content/common/sandbox_policy_fuchsia.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include "content/common/sandbox_policy_fuchsia.h"

#include <launchpad/launchpad.h>
#include <lib/fdio/spawn.h>
#include <zircon/processargs.h>

#include "base/base_paths_fuchsia.h"
Expand Down
10 changes: 0 additions & 10 deletions third_party/fuchsia-sdk/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -193,16 +193,6 @@ fuchsia_sdk_fidl_pkg("input") {
]
}

# TODO(https://crbug.com/848028): Remove this once no dependencies need it.
fuchsia_sdk_pkg("launchpad") {
sources = [
"include/launchpad/launchpad.h",
"include/launchpad/vmo.h",
]

libs = [ "launchpad" ]
}

fuchsia_sdk_fidl_pkg("math") {
namespace = "fuchsia"
namespace_path = "fuchsia"
Expand Down

0 comments on commit 808ccb5

Please sign in to comment.