Skip to content

Commit

Permalink
[Metrics] Remove nohle@ from metrics owners
Browse files Browse the repository at this point in the history
nohle@ no longer works on Chrome OS.

Change-Id: If47dc0e82e70556e32ba6e1104c339621ff35ecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3680918
Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Crisrael Lucero <crisrael@google.com>
Cr-Commit-Position: refs/heads/main@{#1009282}
  • Loading branch information
crisrael authored and Chromium LUCI CQ committed May 31, 2022
1 parent b1e6ea8 commit 7fb102f
Show file tree
Hide file tree
Showing 16 changed files with 136 additions and 143 deletions.
4 changes: 2 additions & 2 deletions WATCHLISTS
Original file line number Diff line number Diff line change
Expand Up @@ -2664,7 +2664,6 @@
'minidump_tests': ['bsheedy@chromium.org'],
'multidevice': ['danlee+watch-multidevice@google.com',
'hansberry+watch-multidevice@chromium.org',
'nohle+watch-multidevice@chromium.org',
'themaxli+watch-multidevice@chromium.org'],
'multipaste': ['andrewxu+watch-multipaste@google.com',
'dmblack+watch-multipaste@google.com',
Expand All @@ -2676,12 +2675,13 @@
'creis+watch@chromium.org',
'navigation-cc+reviews@chromium.org'],
'nearby': ['cclem+watch-nearby@google.com',
'crisrael+watch-nearby@google.com',
'danlee+watch-nearby@google.com',
'hais+watch-nearby@google.com',
'hansberry+watch-nearby@chromium.org',
'hansenmichael+watch-nearby@google.com',
'knollr+watch-nearby@chromium.org',
'nohle+watch-nearby@chromium.org',
'pushi+watch-nearby@google.com',
'xlythe+watch-nearby@google.com'],
'net': ['net-reviews@chromium.org'],
'net_base': ['bnc+watch@chromium.org'],
Expand Down
1 change: 0 additions & 1 deletion ash/components/multidevice/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
hansberry@chromium.org
jonmann@chromium.org
khorimoto@chromium.org
nohle@chromium.org
1 change: 0 additions & 1 deletion ash/components/phonehub/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
hansberry@chromium.org
jonmann@chromium.org
khorimoto@chromium.org
nohle@chromium.org
2 changes: 1 addition & 1 deletion chrome/browser/ash/arc/nearby_share/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ alanding@chromium.org
melzhang@chromium.org

# For Nearby Share integration:
nohle@chromium.org
hansenmichael@google.com

# For backup:
tsergeant@chromium.org
1 change: 0 additions & 1 deletion chrome/browser/nearby_sharing/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
hansberry@chromium.org
hansenmichael@google.com
nohle@chromium.org
1 change: 0 additions & 1 deletion tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ mthiesse@chromium.org
mutexlox@chromium.org
nancylingwang@chromium.org
nigeltao@chromium.org
nohle@chromium.org
nyquist@chromium.org
olivierli@chromium.org
olivierrobin@chromium.org
Expand Down
2 changes: 1 addition & 1 deletion tools/metrics/histograms/metadata/bluetooth/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS
# Prefer sending CLs to the owners listed below.
# Use chromium-metrics-reviews@google.com as a backup.
chadduffin@chromium.org
crisrael@google.com
khorimoto@chromium.org
nohle@chromium.org
reillyg@chromium.org
2 changes: 1 addition & 1 deletion tools/metrics/histograms/metadata/bluetooth/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ chromium-metrics-reviews@google.com.
<histogram name="Bluetooth.Linux.ConnectToServiceInsecurelyResult"
enum="BluetoothAdapterConnectToServiceInsecurelyResult"
expires_after="2023-02-23">
<owner>nohle@chromium.org</owner>
<owner>hansenmichael@google.com</owner>
<owner>nearby-share-chromeos-eng@google.com</owner>
<summary>
Result of attempting a call to mojom::Adapter::ConnectToServiceInsecurely().
Expand Down
2 changes: 1 addition & 1 deletion tools/metrics/histograms/metadata/chromeos/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS
# Use chromium-metrics-reviews@google.com as a backup.
azeemarshad@chromium.org
chadduffin@chromium.org
crisrael@google.com
jorgelo@chromium.org
khorimoto@chromium.org
nohle@chromium.org
tsergeant@chromium.org
zentaro@chromium.org
2 changes: 1 addition & 1 deletion tools/metrics/histograms/metadata/chromeos/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit.
<owner>cros-oac@google.com</owner>
</variant>
<variant name="NearbyShare" summary="Nearby Share">
<owner>nohle@chromium.org</owner>
<owner>hansenmichael@google.com</owner>
<owner>nearby-share-chromeos-eng@google.com</owner>
</variant>
<variant name="NearbyShareBackgroundScanning"
Expand Down
1 change: 0 additions & 1 deletion tools/metrics/histograms/metadata/cross_device/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS
# Prefer sending CLs to the owners listed below.
# Use chromium-metrics-reviews@google.com as a backup.
crisrael@google.com
nohle@chromium.org
Loading

0 comments on commit 7fb102f

Please sign in to comment.