Skip to content

Commit

Permalink
WebUI: Add TypeScript @types package for OffscreenCanvas
Browse files Browse the repository at this point in the history
Specifically, this adds @types/offscreencanvas as dependency.

Also updates npm_include to have the .d.ts in those packages to be
actually included in the packed node_modules.tar.gz.

The OffscreenCanvas type is removed from TypeScript lib.dom.d.ts in
version 4.4, so the new package is needed for the type of
OffscreenCanvas when upgrading TypeScript compiler to newest version.

This increases the uncompressed node_modules size by about 4k.

Bug: b:213292127, 1285794
Test: compile chrome
Change-Id: I7decde4e775cb08db4e787a8050f3653f1f5eefc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412318
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org>
Auto-Submit: Pi-Hsun Shih <pihsun@chromium.org>
Cr-Commit-Position: refs/heads/main@{#963465}
  • Loading branch information
peter50216 authored and Chromium LUCI CQ committed Jan 26, 2022
1 parent 16dbbcf commit 7a0878e
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 1 deletion.
15 changes: 15 additions & 0 deletions third_party/node/README.chromium
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,21 @@ Local Modifications:
(none)


Name: Type Definition for OffscreenCanvas
Short Name: @types/offscreencanvas
URL: https://www.npmjs.com/package/@types/offscreencanvas
Version: 2019.6.4
License: MIT
Security Critical: No. The types are only used when type checking in Chrome OS.

Description:
This package contains type definitions for offscreencanvas-browser
(https://html.spec.whatwg.org/multipage/canvas.html#the-offscreencanvas-interface).

Local Modifications:
(none)


Name: ESLint JSDoc Plugin
Short Name: eslint-plugin-jsdoc
URL: https://www.npmjs.com/package/eslint-plugin-jsdoc
Expand Down
2 changes: 1 addition & 1 deletion third_party/node/node_modules.tar.gz.sha1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1291471c9ef3dd6fca73dda7b5d0eea1026da863
2f33b35e626e95781b6d35ee6f36e0a26a6d8b30
1 change: 1 addition & 0 deletions third_party/node/npm_include.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
@types/google.analytics
@types/google.analytics/*.d.ts
@types/mocha/index.d.ts
@types/offscreencanvas/index.d.ts
@types/w3c-css-typed-object-model-level-1
@types/w3c-css-typed-object-model-level-1/*.d.ts
@types/w3c-image-capture
Expand Down
11 changes: 11 additions & 0 deletions third_party/node/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions third_party/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"@types/dom-mediacapture-record": "1.0.10",
"@types/google.analytics": "0.0.42",
"@types/mocha": "9.0.0",
"@types/offscreencanvas": "2019.6.4",
"@types/w3c-css-typed-object-model-level-1": "20180410.0.3",
"@types/w3c-image-capture": "1.0.4",
"@types/webrtc": "0.0.29",
Expand Down

0 comments on commit 7a0878e

Please sign in to comment.