Skip to content

Commit

Permalink
Breakpad browser crash test: Re-enable check for .txt file on Windows
Browse files Browse the repository at this point in the history
This check doesn't seem to have failed recently, based on inspecting
several recent logs.

I've added more log output since I disabled this check, so if it does
become flaky again we'll have information to debug it.

BUG=169394
TEST=run_breakpad_browser_process_crash_test in nacl_integration

Review URL: https://codereview.chromium.org/12041091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178725 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
mseaborn@chromium.org committed Jan 25, 2013
1 parent df94149 commit 7560fcb
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,6 @@ def CleanUpTempDir():
'%r file\n' % (dump_file, second_file))
if not os.path.exists(second_file):
sys.stdout.write(msg)
# TODO(mseaborn): Investigate and remove this workaround.
if (options.expected_process_type_for_crash == 'browser' and
sys.platform == 'win32'):
sys.stdout.write('crash_dump_tester: Ignoring this error on Windows '
'because the .txt file is sometimes missing -- '
'see http://crbug.com/169394\n')
continue
failed = True
continue
# Check that the crash dump comes from the NaCl process.
Expand Down

0 comments on commit 7560fcb

Please sign in to comment.