Skip to content

Commit

Permalink
Add Mavericks to test config.
Browse files Browse the repository at this point in the history
BUG=338160
TEST=gpu_unittests on 10.9 bots
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/141753015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248647 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
zmo@chromium.org committed Feb 4, 2014
1 parent 099d672 commit 710089b
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
3 changes: 3 additions & 0 deletions gpu/config/gpu_test_config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ GPUTestConfig::OS GetCurrentOS() {
return GPUTestConfig::kOsMacLion;
case 8:
return GPUTestConfig::kOsMacMountainLion;
case 9:
return GPUTestConfig::kOsMacMavericks;
}
}
#elif defined(OS_ANDROID)
Expand Down Expand Up @@ -169,6 +171,7 @@ bool GPUTestBotConfig::IsValid() const {
case kOsMacSnowLeopard:
case kOsMacLion:
case kOsMacMountainLion:
case kOsMacMavericks:
case kOsLinux:
case kOsChromeOS:
case kOsAndroid:
Expand Down
9 changes: 5 additions & 4 deletions gpu/config/gpu_test_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,12 @@ class GPU_EXPORT GPUTestConfig {
kOsMacSnowLeopard = 1 << 5,
kOsMacLion = 1 << 6,
kOsMacMountainLion = 1 << 7,
kOsMacMavericks = 1 << 8,
kOsMac = kOsMacLeopard | kOsMacSnowLeopard | kOsMacLion |
kOsMacMountainLion,
kOsLinux = 1 << 8,
kOsChromeOS = 1 << 9,
kOsAndroid = 1 << 10,
kOsMacMountainLion | kOsMacMavericks,
kOsLinux = 1 << 9,
kOsChromeOS = 1 << 10,
kOsAndroid = 1 << 11,
};

enum BuildType {
Expand Down
5 changes: 5 additions & 0 deletions gpu/config/gpu_test_expectations_parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ enum Token {
kConfigMacSnowLeopard,
kConfigMacLion,
kConfigMacMountainLion,
kConfigMacMavericks,
kConfigMac,
kConfigLinux,
kConfigChromeOS,
Expand Down Expand Up @@ -81,6 +82,7 @@ const TokenInfo kTokenData[] = {
{ "snowleopard", GPUTestConfig::kOsMacSnowLeopard },
{ "lion", GPUTestConfig::kOsMacLion },
{ "mountainlion", GPUTestConfig::kOsMacMountainLion },
{ "mavericks", GPUTestConfig::kOsMacMavericks },
{ "mac", GPUTestConfig::kOsMac },
{ "linux", GPUTestConfig::kOsLinux },
{ "chromeos", GPUTestConfig::kOsChromeOS },
Expand Down Expand Up @@ -232,6 +234,7 @@ bool GPUTestExpectationsParser::ParseConfig(
case kConfigMacSnowLeopard:
case kConfigMacLion:
case kConfigMacMountainLion:
case kConfigMacMavericks:
case kConfigMac:
case kConfigLinux:
case kConfigChromeOS:
Expand Down Expand Up @@ -282,6 +285,7 @@ bool GPUTestExpectationsParser::ParseLine(
case kConfigMacSnowLeopard:
case kConfigMacLion:
case kConfigMacMountainLion:
case kConfigMacMavericks:
case kConfigMac:
case kConfigLinux:
case kConfigChromeOS:
Expand Down Expand Up @@ -395,6 +399,7 @@ bool GPUTestExpectationsParser::UpdateTestConfig(
case kConfigMacSnowLeopard:
case kConfigMacLion:
case kConfigMacMountainLion:
case kConfigMacMavericks:
case kConfigMac:
case kConfigLinux:
case kConfigChromeOS:
Expand Down
2 changes: 1 addition & 1 deletion gpu/config/gpu_test_expectations_parser_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ TEST_F(GPUTestExpectationsParserTest, ValidUnrelatedTestEntry) {
TEST_F(GPUTestExpectationsParserTest, AllModifiers) {
const std::string text =
"BUG12345 XP VISTA WIN7 WIN8 LEOPARD SNOWLEOPARD LION MOUNTAINLION "
"LINUX CHROMEOS ANDROID "
"MAVERICKS LINUX CHROMEOS ANDROID "
"NVIDIA INTEL AMD VMWARE RELEASE DEBUG : MyTest = "
"PASS FAIL FLAKY TIMEOUT SKIP";

Expand Down

0 comments on commit 710089b

Please sign in to comment.