Skip to content

Commit

Permalink
Android: address lint warnings.
Browse files Browse the repository at this point in the history
All suppressed lint warnings should have a comment explaining why they
are necessary. This CL also removes suppressions that were fixed in
https://codereview.chromium.org/2327833002/.

BUG=635567

Review-Url: https://codereview.chromium.org/2707973007
Cr-Commit-Position: refs/heads/master@{#452273}
  • Loading branch information
estevenson authored and Commit bot committed Feb 22, 2017
1 parent 807ffe0 commit 6d3d021
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions build/android/lint/suppressions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ Still reading?
Note: PRODUCT_DIR will be substituted at run-time with actual
directory path (e.g. out/Debug)
-->
<!-- AllowBackup defaults to true, and causes a lint warning if not explicitly set. -->
<issue id="AllowBackup">
<ignore path="AndroidManifest.xml"/>
</issue>
<!-- We use asserts in Chromium. See https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Asserts -->
<issue id="Assert" severity="ignore"/>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="BadHostnameVerifier" severity="Error">
<!-- Safe, used in test only. -->
<ignore regexp="net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java"/>
</issue>
<issue id="ButtonOrder" severity="Error">
Expand Down Expand Up @@ -73,12 +75,6 @@ Still reading?
</issue>
<issue id="HandlerLeak">
<ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java" />
<!-- TODO(crbug.com/635567): Fix this properly. -->
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java"/>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java"/>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java"/>
<ignore regexp="chromecast/internal" />
<ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java" />
</issue>
Expand Down

0 comments on commit 6d3d021

Please sign in to comment.