Skip to content

Commit

Permalink
Revert "Temporarily add UMA histogram for IPC message sizes."
Browse files Browse the repository at this point in the history
This reverts commit 5961c6d.

Reason for revert: enough data was collected (see the bug).

BUG=529940

Review URL: https://codereview.chromium.org/1417583006

Cr-Commit-Position: refs/heads/master@{#356935}
  • Loading branch information
dskiba authored and Commit bot committed Oct 29, 2015
1 parent fe1f35d commit 5fe8f37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ipc/ipc_channel_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <algorithm>

#include "base/metrics/histogram_macros.h"
#include "ipc/ipc_listener.h"
#include "ipc/ipc_logging.h"
#include "ipc/ipc_message.h"
Expand Down Expand Up @@ -137,9 +136,6 @@ bool ChannelReader::TranslateInputData(const char* input_data,
bool ChannelReader::HandleTranslatedMessage(
Message* translated_message,
const AttachmentIdVector& attachment_ids) {
UMA_HISTOGRAM_MEMORY_KB(
"Memory.IPCChannelReader.ReceivedMessageSize",
static_cast<base::HistogramBase::Sample>(translated_message->size()));

// Immediately handle internal messages.
if (IsInternalMessage(*translated_message)) {
Expand Down
3 changes: 3 additions & 0 deletions tools/metrics/histograms/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18928,6 +18928,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>

<histogram name="Memory.IPCChannelReader.ReceivedMessageSize" units="bytes">
<obsolete>
Obsolete as of 11/2015
</obsolete>
<owner>dskiba@chromium.org</owner>
<summary>Size of messages received by IPC::ChannelReader.</summary>
</histogram>
Expand Down

0 comments on commit 5fe8f37

Please sign in to comment.