Skip to content

Commit

Permalink
Re-enable SpokenFeedbackTest.SpeakingTextUnderMouseForShelfItem
Browse files Browse the repository at this point in the history
Removes opening of web page which appears to be causing flakes according to logs.

TBR=dtseng@chromium.org

Fixed: 1065877
Change-Id: Ie80e84bfd1df56bff60d4d55292c3a8825c850d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210656
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770771}
  • Loading branch information
dtsengchromium authored and Commit Bot committed May 20, 2020
1 parent 2c1d888 commit 5cc2f76
Showing 1 changed file with 1 addition and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -371,21 +371,12 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, ShelfIconFocusForward) {

// Verifies that speaking text under mouse works for Shelf button and voice
// announcements should not be stacked when mouse goes over many Shelf buttons
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest,
DISABLED_SpeakingTextUnderMouseForShelfItem) {
IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, SpeakingTextUnderMouseForShelfItem) {
// Add the ShelfItem to the ShelfModel after enabling the ChromeVox. Because
// when an extension is enabled, the ShelfItems which are not recorded as
// pinned apps in user preference will be removed.
EnableChromeVox();

sm_.Call([this]() {
ui_test_utils::NavigateToURL(browser(),
GURL("data:text/html;charset=utf-8,<button "
"autofocus>Click me</button>"));
});

sm_.ExpectSpeech("Click me");

sm_.Call([this]() {
// Add three Shelf buttons. Wait for the change on ShelfModel to reach ash.
ChromeLauncherController* controller = ChromeLauncherController::instance();
Expand Down

0 comments on commit 5cc2f76

Please sign in to comment.