Skip to content

Commit

Permalink
Merge service_manager::BinderMapWithContext into mojo::BinderMap
Browse files Browse the repository at this point in the history
Tbr: oksamyt@chromium.org
Bug: 1046578
Change-Id: Ic2c01ee09c4b6a9fb2a936acf28fc0f00dc053f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174654
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765090}
  • Loading branch information
rsesek authored and Commit Bot committed May 4, 2020
1 parent bc6538d commit 5a5fbb8
Show file tree
Hide file tree
Showing 58 changed files with 216 additions and 421 deletions.
4 changes: 2 additions & 2 deletions chrome/browser/chrome_browser_interface_binders.cc
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ void BindCaptionContextHandler(
#endif

void PopulateChromeFrameBinders(
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map) {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) {
map->Add<image_annotation::mojom::Annotator>(
base::BindRepeating(&BindImageAnnotator));

Expand Down Expand Up @@ -448,7 +448,7 @@ void PopulateChromeFrameBinders(
}

void PopulateChromeWebUIFrameBinders(
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map) {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) {
RegisterWebUIControllerInterfaceBinder<::mojom::BluetoothInternalsHandler,
BluetoothInternalsUI>(map);

Expand Down
8 changes: 4 additions & 4 deletions chrome/browser/chrome_browser_interface_binders.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "content/public/browser/web_ui_controller.h"
#include "services/service_manager/public/cpp/binder_map.h"
#include "mojo/public/cpp/bindings/binder_map.h"

namespace content {

Expand All @@ -28,13 +28,13 @@ namespace internal {
// GetInterface() handler callbacks for chrome-specific document-scoped
// interfaces.
void PopulateChromeFrameBinders(
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map);
mojo::BinderMapWithContext<content::RenderFrameHost*>* map);

// PopulateChromeWebUIFrameBinders() registers BrowserInterfaceBroker's
// GetInterface() handler callbacks for chrome-specific document-scoped
// interfaces used from WebUI pages (e.g. chrome://bluetooth-internals).
void PopulateChromeWebUIFrameBinders(
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map);
mojo::BinderMapWithContext<content::RenderFrameHost*>* map);

template <typename Interface, int N, typename... Subclasses>
struct BinderHelper;
Expand Down Expand Up @@ -83,7 +83,7 @@ struct BinderHelper<Interface, 0, std::tuple<Subclass, Subclasses...>> {
// has a WebUIController among type |WebUIControllerSubclasses|.
template <typename Interface, typename... WebUIControllerSubclasses>
void RegisterWebUIControllerInterfaceBinder(
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map) {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) {
map->Add<Interface>(
base::BindRepeating([](content::RenderFrameHost* host,
mojo::PendingReceiver<Interface> receiver) {
Expand Down
3 changes: 1 addition & 2 deletions chrome/browser/chrome_content_browser_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,7 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
mojo::GenericPendingReceiver receiver) override;
void RegisterBrowserInterfaceBindersForFrame(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map)
override;
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) override;
bool BindAssociatedReceiverFromFrame(
content::RenderFrameHost* render_frame_host,
const std::string& interface_name,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ void ChromeContentBrowserClient::BindMediaServiceReceiver(

void ChromeContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map) {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) {
chrome::internal::PopulateChromeFrameBinders(map);
chrome::internal::PopulateChromeWebUIFrameBinders(map);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,7 @@ ChromeExtensionsBrowserClient::GetExtensionSystemFactory() {
}

void ChromeExtensionsBrowserClient::RegisterBrowserInterfaceBindersForFrame(
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map,
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map,
content::RenderFrameHost* render_frame_host,
const Extension* extension) const {
PopulateExtensionFrameBinders(binder_map, render_frame_host, extension);
Expand Down
3 changes: 1 addition & 2 deletions chrome/browser/extensions/chrome_extensions_browser_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ class ChromeExtensionsBrowserClient : public ExtensionsBrowserClient {
bool IsLoggedInAsPublicAccount() override;
ExtensionSystemProvider* GetExtensionSystemFactory() override;
void RegisterBrowserInterfaceBindersForFrame(
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map,
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map,
content::RenderFrameHost* render_frame_host,
const Extension* extension) const override;
std::unique_ptr<RuntimeAPIDelegate> CreateRuntimeAPIDelegate(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@ void ConnectToCameraAppHelper(
} // namespace

void PopulateChromeFrameBindersForExtension(
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map,
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map,
content::RenderFrameHost* render_frame_host,
const Extension* extension) {
DCHECK(extension);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_INTERFACE_BINDERS_H_
#define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_INTERFACE_BINDERS_H_

#include "services/service_manager/public/cpp/binder_map.h"
#include "mojo/public/cpp/bindings/binder_map.h"

namespace content {
class RenderFrameHost;
Expand All @@ -16,8 +16,7 @@ namespace extensions {
class Extension;

void PopulateChromeFrameBindersForExtension(
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map,
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map,
content::RenderFrameHost* render_frame_host,
const Extension* extension);

Expand Down
5 changes: 2 additions & 3 deletions chrome/test/base/mojo_web_ui_browser_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_client.h"
#include "mojo/public/cpp/bindings/binder_map.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "services/service_manager/public/cpp/binder_map.h"
#include "ui/base/resource/resource_bundle.h"

namespace {
Expand Down Expand Up @@ -68,8 +68,7 @@ class MojoWebUIBrowserTest::WebUITestContentBrowserClient

void RegisterBrowserInterfaceBindersForFrame(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map)
override {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) override {
ChromeContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(
render_frame_host, map);
map->Add<web_ui_test::mojom::TestRunner>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/no_renderer_crashes_assertion.h"
#include "content/public/test/test_utils.h"
#include "services/service_manager/public/cpp/binder_map.h"
#include "mojo/public/cpp/bindings/binder_map.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/resource/resource_bundle.h"
#include "url/gurl.h"
Expand Down Expand Up @@ -182,8 +182,7 @@ class MojoWebUIControllerBrowserTest : public InProcessBrowserTest {

void RegisterBrowserInterfaceBindersForFrame(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map)
override {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) override {
ChromeContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(
render_frame_host, map);
chrome::internal::RegisterWebUIControllerInterfaceBinder<
Expand Down
3 changes: 1 addition & 2 deletions chromecast/browser/cast_browser_interface_binders.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ void BindApplicationMediaCapabilities(

void PopulateCastFrameBinders(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map) {
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map) {
binder_map->Add<network_hints::mojom::NetworkHintsHandler>(
base::BindRepeating(&BindNetworkHintsHandler));
binder_map->Add<mojom::ApplicationMediaCapabilities>(
Expand Down
5 changes: 2 additions & 3 deletions chromecast/browser/cast_browser_interface_binders.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#ifndef CHROMECAST_BROWSER_CAST_BROWSER_INTERFACE_BINDERS_H_
#define CHROMECAST_BROWSER_CAST_BROWSER_INTERFACE_BINDERS_H_

#include "services/service_manager/public/cpp/binder_map.h"
#include "mojo/public/cpp/bindings/binder_map.h"

namespace content {
class RenderFrameHost;
Expand All @@ -16,8 +16,7 @@ namespace shell {

void PopulateCastFrameBinders(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map);
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map);

} // namespace shell
} // namespace chromecast
Expand Down
3 changes: 1 addition & 2 deletions chromecast/browser/cast_content_browser_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,7 @@ class CastContentBrowserClient
mojo::GenericPendingReceiver receiver) override;
void RegisterBrowserInterfaceBindersForFrame(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map)
override;
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) override;
mojo::Remote<::media::mojom::MediaService> RunSecondaryMediaService()
override;
void RunServiceInstance(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
#include "components/cdm/browser/media_drm_storage_impl.h"
#include "content/public/browser/render_process_host.h"
#include "media/mojo/buildflags.h"
#include "mojo/public/cpp/bindings/binder_map.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "services/service_manager/public/cpp/binder_map.h"
#include "url/origin.h"

#if BUILDFLAG(ENABLE_CAST_RENDERER)
Expand Down Expand Up @@ -139,7 +139,7 @@ void CastContentBrowserClient::BindMediaServiceReceiver(

void CastContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(
content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map) {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) {
PopulateCastFrameBinders(render_frame_host, map);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,7 @@ CastExtensionsBrowserClient::GetExtensionSystemFactory() {
}

void CastExtensionsBrowserClient::RegisterBrowserInterfaceBindersForFrame(
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map,
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map,
content::RenderFrameHost* render_frame_host,
const Extension* extension) const {
PopulateExtensionFrameBinders(binder_map, render_frame_host, extension);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ class CastExtensionsBrowserClient : public ExtensionsBrowserClient {
bool IsLoggedInAsPublicAccount() override;
ExtensionSystemProvider* GetExtensionSystemFactory() override;
void RegisterBrowserInterfaceBindersForFrame(
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
binder_map,
mojo::BinderMapWithContext<content::RenderFrameHost*>* binder_map,
content::RenderFrameHost* render_frame_host,
const Extension* extension) const override;
std::unique_ptr<RuntimeAPIDelegate> CreateRuntimeAPIDelegate(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <memory>

#include "services/service_manager/public/cpp/binder_map.h"
#include "mojo/public/cpp/bindings/binder_map.h"
#include "services/service_manager/public/cpp/binder_registry.h"

namespace content {
Expand Down Expand Up @@ -82,8 +82,7 @@ class PerformanceManagerRegistry {
// FrameNode in the graph. Typically wired up via
// ContentBrowserClient::RegisterBrowserInterfaceBindersForFrame.
virtual void ExposeInterfacesToRenderFrame(
service_manager::BinderMapWithContext<content::RenderFrameHost*>*
map) = 0;
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) = 0;

// Must be invoked prior to destroying the object. Schedules deletion of
// PageNodes and ProcessNodes retained by this registry, even if the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ void PerformanceManagerRegistryImpl::
}

void PerformanceManagerRegistryImpl::ExposeInterfacesToRenderFrame(
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map) {
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) {
map->Add<performance_manager::mojom::DocumentCoordinationUnit>(
base::BindRepeating(&BindDocumentCoordinationUnit));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ class PerformanceManagerRegistryImpl
service_manager::BinderRegistry* registry,
content::RenderProcessHost* render_process_host) override;
void ExposeInterfacesToRenderFrame(
service_manager::BinderMapWithContext<content::RenderFrameHost*>* map)
override;
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) override;
void TearDown() override;

// PerformanceManagerTabHelper::DestructionObserver:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "content/public/common/content_switches.h"
#include "content/shell/browser/shell.h"
#include "content/shell/browser/shell_content_browser_client.h"
#include "services/service_manager/public/cpp/binder_map.h"
#include "mojo/public/cpp/bindings/binder_map.h"
#include "services/service_manager/public/cpp/binder_registry.h"

namespace performance_manager {
Expand Down Expand Up @@ -59,12 +59,12 @@ void PerformanceManagerBrowserTestHarness::CreatedBrowserMainParts(
// Expose interfaces to RenderFrame.
content::ShellContentBrowserClient::Get()
->set_register_browser_interface_binders_for_frame_callback(
base::BindRepeating([](content::RenderFrameHost* render_frame_host,
service_manager::BinderMapWithContext<
content::RenderFrameHost*>* map) {
PerformanceManagerRegistry::GetInstance()
->ExposeInterfacesToRenderFrame(map);
}));
base::BindRepeating(
[](content::RenderFrameHost* render_frame_host,
mojo::BinderMapWithContext<content::RenderFrameHost*>* map) {
PerformanceManagerRegistry::GetInstance()
->ExposeInterfacesToRenderFrame(map);
}));
}

content::Shell* PerformanceManagerBrowserTestHarness::CreateShell() {
Expand Down
Loading

0 comments on commit 5a5fbb8

Please sign in to comment.