cc: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add missing ones in cc header files. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2503283002 Cr-Commit-Position: refs/heads/master@{#432964}
qweri0p · Nov 17, 2016 · 58f2876 · 58f2876
1 parent 2ca4b1f
commit 58f2876
Show file tree

Hide file tree

Showing 86 changed files with 11 additions and 237 deletions.
diff --git a/blimp/client/support/compositor/blimp_embedder_compositor.h b/blimp/client/support/compositor/blimp_embedder_compositor.h
@@ -16,6 +16,7 @@
 
 namespace cc {
 class AnimationHost;
+class ContextProvider;
 class Display;
 class LayerTreeHost;
 class SurfaceManager;

diff --git a/cc/animation/animation_curve.h b/cc/animation/animation_curve.h
@@ -23,7 +23,6 @@ class FilterAnimationCurve;
 class FloatAnimationCurve;
 class ScrollOffsetAnimationCurve;
 class TransformAnimationCurve;
-class TransformOperations;
 
 // An animation curve is a function that returns a value given a time.
 class CC_EXPORT AnimationCurve {

diff --git a/cc/animation/element_animations.h b/cc/animation/element_animations.h
@@ -25,7 +25,6 @@ class BoxF;
 
 namespace cc {
 
-class AnimationDelegate;
 class AnimationEvents;
 class AnimationHost;
 class AnimationPlayer;

diff --git a/cc/animation/scroll_offset_animations_impl.h b/cc/animation/scroll_offset_animations_impl.h
@@ -18,7 +18,6 @@ namespace cc {
 class AnimationPlayer;
 class AnimationHost;
 class AnimationTimeline;
-class ElementAnimations;
 
 // Contains an AnimationTimeline and its AnimationPlayer that owns the impl
 // only scroll offset animations running on a particular CC Layer.

diff --git a/cc/blimp/layer_tree_host_remote.h b/cc/blimp/layer_tree_host_remote.h
@@ -26,7 +26,6 @@ class LayerTreeHost;
 
 class MutatorHost;
 class EnginePictureCache;
-class ImageSerializationProcessor;
 class RemoteCompositorBridge;
 class LayerTreeHostClient;
 

diff --git a/cc/blimp/remote_compositor_bridge_client.h b/cc/blimp/remote_compositor_bridge_client.h
@@ -18,7 +18,6 @@ namespace cc {
 namespace proto {
 class ClientStateUpdate;
 }  // namespace proto
-class CompositorProtoState;
 
 class CC_EXPORT RemoteCompositorBridgeClient {
  public:

diff --git a/cc/blink/web_content_layer_impl.h b/cc/blink/web_content_layer_impl.h
@@ -15,11 +15,6 @@
 #include "cc/layers/content_layer_client.h"
 #include "third_party/WebKit/public/platform/WebContentLayer.h"
 
-namespace cc {
-class IntRect;
-class FloatRect;
-}
-
 namespace blink {
 class WebContentLayerClient;
 }

diff --git a/cc/blink/web_display_item_list_impl.h b/cc/blink/web_display_item_list_impl.h
@@ -16,7 +16,6 @@
 #include "ui/gfx/geometry/point_f.h"
 
 class SkColorFilter;
-class SkImageFilter;
 class SkMatrix44;
 class SkPath;
 class SkPicture;
@@ -29,7 +28,6 @@ struct WebRect;
 }
 
 namespace cc {
-class DisplayItemListSettings;
 class FilterOperations;
 }
 

diff --git a/cc/blink/web_layer_impl.h b/cc/blink/web_layer_impl.h
@@ -28,16 +28,6 @@
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/skia/include/core/SkMatrix44.h"
 
-namespace blink {
-struct WebFloatRect;
-}
-
-namespace base {
-namespace trace_event {
-class ConvertableToTraceFormat;
-}
-}
-
 namespace cc {
 class FilterOperations;
 class Layer;

diff --git a/cc/debug/invalidation_benchmark.h b/cc/debug/invalidation_benchmark.h
@@ -14,7 +14,7 @@
 namespace cc {
 
 class LayerTree;
-class Layer;
+
 // NOTE: this benchmark will not measure or return any results, it will simply
 // invalidate a certain area of each layer every frame. It is intended to be
 // used in combination with a telemetry benchmark that does the actual

diff --git a/cc/debug/rasterize_and_record_benchmark.h b/cc/debug/rasterize_and_record_benchmark.h
@@ -24,7 +24,6 @@ class DictionaryValue;
 namespace cc {
 
 class LayerTree;
-class Layer;
 
 class RasterizeAndRecordBenchmark : public MicroBenchmark {
  public:

diff --git a/cc/debug/rasterize_and_record_benchmark_impl.h b/cc/debug/rasterize_and_record_benchmark_impl.h
@@ -20,7 +20,7 @@ namespace cc {
 
 class LayerTreeHostImpl;
 class PictureLayerImpl;
-class LayerImpl;
+
 class RasterizeAndRecordBenchmarkImpl : public MicroBenchmarkImpl {
  public:
   explicit RasterizeAndRecordBenchmarkImpl(

diff --git a/cc/input/browser_controls_offset_manager.h b/cc/input/browser_controls_offset_manager.h
@@ -17,7 +17,6 @@
 
 namespace cc {
 
-class LayerTreeImpl;
 class BrowserControlsOffsetManagerClient;
 
 // Manages the position of the browser controls.

diff --git a/cc/input/browser_controls_offset_manager_client.h b/cc/input/browser_controls_offset_manager_client.h
@@ -7,8 +7,6 @@
 
 namespace cc {
 
-class LayerTreeImpl;
-
 class CC_EXPORT BrowserControlsOffsetManagerClient {
  public:
   virtual float TopControlsHeight() const = 0;

diff --git a/cc/input/input_handler.h b/cc/input/input_handler.h
@@ -18,10 +18,8 @@
 
 namespace gfx {
 class Point;
-class PointF;
 class ScrollOffset;
 class SizeF;
-class Vector2d;
 class Vector2dF;
 }
 

diff --git a/cc/input/scrollbar_animation_controller_linear_fade.h b/cc/input/scrollbar_animation_controller_linear_fade.h
@@ -12,7 +12,6 @@
 #include "cc/input/scrollbar_animation_controller.h"
 
 namespace cc {
-class LayerImpl;
 
 class CC_EXPORT ScrollbarAnimationControllerLinearFade
     : public ScrollbarAnimationController {

diff --git a/cc/input/scrollbar_animation_controller_thinning.h b/cc/input/scrollbar_animation_controller_thinning.h
@@ -12,7 +12,6 @@
 #include "cc/input/scrollbar_animation_controller.h"
 
 namespace cc {
-class LayerImpl;
 
 // Scrollbar animation that partially fades and thins after an idle delay,
 // and reacts to mouse movements.

diff --git a/cc/ipc/cc_param_traits.h b/cc/ipc/cc_param_traits.h
@@ -17,10 +17,6 @@
 #include "gpu/ipc/common/gpu_command_buffer_traits.h"
 #include "ipc/ipc_message_macros.h"
 
-namespace gfx {
-class Transform;
-}
-
 namespace cc {
 class FilterOperations;
 }

diff --git a/cc/layers/heads_up_display_layer.h b/cc/layers/heads_up_display_layer.h
@@ -16,10 +16,6 @@
 
 namespace cc {
 
-namespace proto {
-class LayerNode;
-}  // namespace proto
-
 class CC_EXPORT HeadsUpDisplayLayer : public Layer {
  public:
   static scoped_refptr<HeadsUpDisplayLayer> Create();

diff --git a/cc/layers/heads_up_display_layer_impl.h b/cc/layers/heads_up_display_layer_impl.h
@@ -27,7 +27,6 @@ struct SkRect;
 namespace cc {
 
 class FrameRateCounter;
-class PaintTimeCounter;
 
 class CC_EXPORT HeadsUpDisplayLayerImpl : public LayerImpl {
  public:

diff --git a/cc/layers/layer.h b/cc/layers/layer.h
@@ -39,10 +39,6 @@
 #include "ui/gfx/geometry/scroll_offset.h"
 #include "ui/gfx/transform.h"
 
-namespace gfx {
-class BoxF;
-}
-
 namespace base {
 namespace trace_event {
 class ConvertableToTraceFormat;
@@ -52,23 +48,17 @@ class ConvertableToTraceFormat;
 namespace cc {
 
 class CopyOutputRequest;
-class LayerAnimationEventObserver;
 class LayerClient;
 class LayerImpl;
 class LayerTreeHost;
 class LayerTreeHostCommon;
 class LayerTreeImpl;
-class LayerTreeSettings;
 class MutatorHost;
-class RenderingStatsInstrumentation;
-class ResourceUpdateQueue;
 class ScrollbarLayerInterface;
-class SimpleEnclosedRegion;
 
 namespace proto {
 class LayerNode;
 class LayerProperties;
-class LayerUpdate;
 }  // namespace proto
 
 // Base class for composited layers. Special layer types are derived from

diff --git a/cc/layers/layer_impl.h b/cc/layers/layer_impl.h
@@ -52,20 +52,14 @@ class DictionaryValue;
 
 namespace cc {
 
-class LayerTreeHostImpl;
 class LayerTreeImpl;
 class MicroBenchmarkImpl;
 class MutatorHost;
-class Occlusion;
-class EffectTree;
 class PrioritizedTile;
 class RenderPass;
-class RenderPassId;
-class Renderer;
 class ScrollbarLayerImplBase;
 class SimpleEnclosedRegion;
 class Tile;
-class TransformTree;
 class ScrollState;
 
 struct AppendQuadsData;

diff --git a/cc/layers/layer_list_iterator.h b/cc/layers/layer_list_iterator.h
@@ -12,7 +12,6 @@
 
 namespace cc {
 
-class Layer;
 class LayerImpl;
 
 // Unlike LayerIterator and friends, these iterators are not intended to permit

diff --git a/cc/layers/nine_patch_layer.h b/cc/layers/nine_patch_layer.h
@@ -16,9 +16,6 @@
 
 namespace cc {
 
-class LayerTreeHost;
-class ScopedUIResource;
-
 class CC_EXPORT NinePatchLayer : public UIResourceLayer {
  public:
   static scoped_refptr<NinePatchLayer> Create();

diff --git a/cc/layers/painted_scrollbar_layer.h b/cc/layers/painted_scrollbar_layer.h
@@ -14,7 +14,6 @@
 #include "cc/resources/scoped_ui_resource.h"
 
 namespace cc {
-class ScrollbarThemeComposite;
 
 class CC_EXPORT PaintedScrollbarLayer : public ScrollbarLayerInterface,
                                         public Layer {

diff --git a/cc/layers/painted_scrollbar_layer_impl.h b/cc/layers/painted_scrollbar_layer_impl.h
@@ -14,7 +14,6 @@
 namespace cc {
 
 class LayerTreeImpl;
-class ScrollView;
 
 class CC_EXPORT PaintedScrollbarLayerImpl : public ScrollbarLayerImplBase {
  public:

diff --git a/cc/layers/picture_layer.h b/cc/layers/picture_layer.h
@@ -13,14 +13,9 @@
 
 namespace cc {
 
-namespace proto {
-class PictureLayerProperties;
-}
-
 class ContentLayerClient;
 class DisplayItemList;
 class RecordingSource;
-class ResourceUpdateQueue;
 
 class CC_EXPORT PictureLayer : public Layer {
  public:

diff --git a/cc/layers/scrollbar_layer_interface.h b/cc/layers/scrollbar_layer_interface.h
@@ -11,9 +11,6 @@
 
 namespace cc {
 
-class Layer;
-class LayerImpl;
-
 class CC_EXPORT ScrollbarLayerInterface {
  public:
   virtual int ScrollLayerId() const = 0;

diff --git a/cc/layers/texture_layer_client.h b/cc/layers/texture_layer_client.h
@@ -8,7 +8,6 @@
 #include "cc/resources/single_release_callback.h"
 
 namespace cc {
-class ResourceUpdateQueue;
 class TextureMailbox;
 
 class TextureLayerClient {

diff --git a/cc/layers/ui_resource_layer.h b/cc/layers/ui_resource_layer.h
@@ -16,7 +16,6 @@
 namespace cc {
 
 class LayerTreeHost;
-class ScopedUIResource;
 
 class CC_EXPORT UIResourceLayer : public Layer {
  public:

diff --git a/cc/output/compositor_frame_sink.h b/cc/output/compositor_frame_sink.h
@@ -19,25 +19,13 @@
 #include "gpu/command_buffer/common/texture_in_use_response.h"
 #include "ui/gfx/color_space.h"
 
-namespace ui {
-class LatencyInfo;
-}
-
-namespace gfx {
-class ColorSpace;
-class Rect;
-class Size;
-class Transform;
-}
-
 namespace gpu {
 class GpuMemoryBufferManager;
 }
 
 namespace cc {
 
 class CompositorFrame;
-struct ManagedMemoryPolicy;
 class CompositorFrameSinkClient;
 class SharedBitmapManager;
 

diff --git a/cc/output/context_provider.h b/cc/output/context_provider.h
@@ -27,7 +27,6 @@ namespace gles2 { class GLES2Interface; }
 }
 
 namespace cc {
-struct ManagedMemoryPolicy;
 
 class ContextProvider : public base::RefCountedThreadSafe<ContextProvider> {
  public:

diff --git a/cc/output/dynamic_geometry_binding.h b/cc/output/dynamic_geometry_binding.h
@@ -8,6 +8,10 @@
 #include "base/macros.h"
 #include "cc/output/geometry_binding.h"
 
+namespace gfx {
+class QuadF;
+}
+
 namespace cc {
 
 class DynamicGeometryBinding {

diff --git a/cc/output/filter_operation.h b/cc/output/filter_operation.h
@@ -19,7 +19,6 @@ namespace base {
 namespace trace_event {
 class TracedValue;
 }
-class Value;
 }
 
 namespace gfx {

diff --git a/cc/output/filter_operations.h b/cc/output/filter_operations.h
@@ -17,7 +17,6 @@ namespace base {
 namespace trace_event {
 class TracedValue;
 }
-class Value;
 }
 
 namespace gfx {
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,6 @@ namespace gles2 { class GLES2Interface; } @@
     }
     namespace cc {
-    struct ManagedMemoryPolicy;
     class ContextProvider : public base::RefCountedThreadSafe<ContextProvider> {
      public:
@@ Expand Down @@