Skip to content

Commit

Permalink
DevTools: use sentence case instead of title case in secondary labels…
Browse files Browse the repository at this point in the history
…, buttons, and tooltips

BUG=724639

Review-Url: https://codereview.chromium.org/2915333002
Cr-Commit-Position: refs/heads/master@{#476880}
  • Loading branch information
psybuzz authored and Commit Bot committed Jun 3, 2017
1 parent 9b2a822 commit 47dd4cc
Show file tree
Hide file tree
Showing 24 changed files with 43 additions and 43 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ console-dir.html:19 ƒ anonymous()
console-dir.html:23 inner
__proto__: Object
console-dir.html:26 Object
No Properties
No properties
console-dir.html:27 Object
foo:
No Properties
No properties
__proto__: Object
console-dir.html:29 ƒ __proto__()
arguments: null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -593,14 +593,14 @@ console-format.html:8 [-0]
globals[27]
-0
console-format.html:7 {}
No Properties
No properties
console-format.html:8 [{…}]
0: {}
length: 1
__proto__: Array(0)
globals[28]
{}
No Properties
No properties
console-format.html:7 ƒ Object() { [native code] }
console-format.html:8 [ƒ]
0: ƒ Object()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ Breakpoint sidebar pane
disable-breakpoints.html:8 var x = Math.sqrt(10);
Breakpoints removed.
Breakpoint sidebar pane
No Breakpoints
No breakpoints

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Call stack:
Breakpoint sidebar pane
set-breakpoint.html:17 var x = Math.sqrt(10);
Breakpoint sidebar pane
No Breakpoints
No breakpoints
Script execution resumed.

Running: testSetBreakpointOnTheLastLine
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Call stack:
Breakpoint sidebar pane
set-conditional-breakpoint.html:17 var x = Math.sqrt(10);
Breakpoint sidebar pane
No Breakpoints
No breakpoints
Script execution resumed.

Running: testSetConditionalBreakpointThatDoesNotBreak
Expand All @@ -23,5 +23,5 @@ Breakpoint sidebar pane
set-conditional-breakpoint.html:17 var x = Math.sqrt(10);
Breakpoints removed.
Breakpoint sidebar pane
No Breakpoints
No breakpoints

Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ Script execution paused.
Breakpoint sidebar pane while paused in pretty printed
unformatted2.js:formatted:4 var c = 3;
Breakpoint sidebar pane while paused in raw
No Breakpoints
No breakpoints
Script execution resumed.

Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ Script execution paused.
Breakpoint sidebar pane while paused in pretty printed
unformatted3.js:formatted:4 var c = 3;
Breakpoint sidebar pane while paused in raw
No Breakpoints
No breakpoints
Script execution resumed.

Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ Call stack:
Breakpoint sidebar pane
js-with-inline-stylesheets.html:10 var x = Math.sqrt(10);
Breakpoint sidebar pane
No Breakpoints
No breakpoints
Script execution resumed.

Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Components.DOMBreakpointsSidebarPane = class extends UI.VBox {

this._listElement = this.contentElement.createChild('div', 'breakpoint-list hidden');
this._emptyElement = this.contentElement.createChild('div', 'gray-info-message');
this._emptyElement.textContent = Common.UIString('No Breakpoints');
this._emptyElement.textContent = Common.UIString('No breakpoints');

/** @type {!Map<!SDK.DOMDebuggerModel.DOMBreakpoint, !Components.DOMBreakpointsSidebarPane.Item>} */
this._items = new Map();
Expand Down Expand Up @@ -234,9 +234,9 @@ Components.DOMBreakpointsSidebarPane = class extends UI.VBox {
Components.DOMBreakpointsSidebarPane.Item;

Components.DOMBreakpointsSidebarPane.BreakpointTypeLabels = new Map([
[SDK.DOMDebuggerModel.DOMBreakpoint.Type.SubtreeModified, Common.UIString('Subtree Modified')],
[SDK.DOMDebuggerModel.DOMBreakpoint.Type.AttributeModified, Common.UIString('Attribute Modified')],
[SDK.DOMDebuggerModel.DOMBreakpoint.Type.NodeRemoved, Common.UIString('Node Removed')],
[SDK.DOMDebuggerModel.DOMBreakpoint.Type.SubtreeModified, Common.UIString('Subtree modified')],
[SDK.DOMDebuggerModel.DOMBreakpoint.Type.AttributeModified, Common.UIString('Attribute modified')],
[SDK.DOMDebuggerModel.DOMBreakpoint.Type.NodeRemoved, Common.UIString('Node removed')],
]);

Components.DOMBreakpointsSidebarPane.BreakpointTypeNouns = new Map([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ EventListeners.EventListenersView = class {
this._treeOutline.element.classList.add('monospace');
this._element.appendChild(this._treeOutline.element);
this._emptyHolder = createElementWithClass('div', 'gray-info-message');
this._emptyHolder.textContent = Common.UIString('No Event Listeners');
this._emptyHolder.textContent = Common.UIString('No event listeners');
this._linkifier = new Components.Linkifier();
/** @type {!Map<string, !EventListeners.EventListenersTreeElement>} */
this._treeItemMap = new Map();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,18 @@ Main.RenderingOptionsView = class extends UI.VBox {
this.registerRequiredCSS('main/renderingOptions.css');

this._appendCheckbox(
Common.UIString('Paint Flashing'),
Common.UIString('Paint flashing'),
Common.UIString('Highlights areas of the page (green) that need to be repainted'),
Common.moduleSetting('showPaintRects'));
this._appendCheckbox(
Common.UIString('Layer Borders'), Common.UIString('Shows layer borders (orange/olive) and tiles (cyan)'),
Common.UIString('Layer borders'), Common.UIString('Shows layer borders (orange/olive) and tiles (cyan)'),
Common.moduleSetting('showDebugBorders'));
this._appendCheckbox(
Common.UIString('FPS Meter'),
Common.UIString('FPS meter'),
Common.UIString('Plots frames per second, frame rate distribution, and GPU memory'),
Common.moduleSetting('showFPSCounter'));
this._appendCheckbox(
Common.UIString('Scrolling Performance Issues'),
Common.UIString('Scrolling performance issues'),
Common.UIString(
'Highlights elements (teal) that can slow down scrolling, including touch & wheel event handlers and other main-thread scrolling situations.'),
Common.moduleSetting('showScrollBottleneckRects'));
Expand All @@ -55,7 +55,7 @@ Main.RenderingOptionsView = class extends UI.VBox {
var mediaSelect = UI.SettingsUI.createControlForSetting(mediaSetting);
if (mediaSelect) {
var mediaRow = this.contentElement.createChild('span', 'media-row');
mediaRow.createChild('label').textContent = Common.UIString('Emulate CSS Media');
mediaRow.createChild('label').textContent = Common.UIString('Emulate CSS media');
mediaRow.createChild('p').textContent = Common.UIString('Forces media type for testing print and screen styles');
mediaRow.appendChild(mediaSelect);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ ObjectUI.ObjectPropertyTreeElement = class extends UI.TreeElement {
if (treeNode.childCount())
return;
var title = createElementWithClass('div', 'gray-info-message');
title.textContent = emptyPlaceholder || Common.UIString('No Properties');
title.textContent = emptyPlaceholder || Common.UIString('No properties');
var infoElement = new UI.TreeElement(title);
treeNode.appendChild(infoElement);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Profiler.HeapProfileView = class extends Profiler.ProfileView {
*/
Profiler.SamplingHeapProfileType = class extends Profiler.ProfileType {
constructor() {
super(Profiler.SamplingHeapProfileType.TypeId, Common.UIString('Record Allocation Profile'));
super(Profiler.SamplingHeapProfileType.TypeId, Common.UIString('Record allocation profile'));
this._recording = false;
Profiler.SamplingHeapProfileType.instance = this;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ Profiler.HeapSnapshotProfileType = class extends Profiler.ProfileType {
* @param {string=} title
*/
constructor(id, title) {
super(id || Profiler.HeapSnapshotProfileType.TypeId, title || Common.UIString('Take Heap Snapshot'));
super(id || Profiler.HeapSnapshotProfileType.TypeId, title || Common.UIString('Take heap snapshot'));
SDK.targetManager.observeModels(SDK.HeapProfilerModel, this);
SDK.targetManager.addModelListener(
SDK.HeapProfilerModel, SDK.HeapProfilerModel.Events.ResetProfiles, this._resetProfiles, this);
Expand Down Expand Up @@ -1128,7 +1128,7 @@ Profiler.HeapSnapshotProfileType.SnapshotReceived = 'SnapshotReceived';
*/
Profiler.TrackingHeapSnapshotProfileType = class extends Profiler.HeapSnapshotProfileType {
constructor() {
super(Profiler.TrackingHeapSnapshotProfileType.TypeId, Common.UIString('Record Allocation Timeline'));
super(Profiler.TrackingHeapSnapshotProfileType.TypeId, Common.UIString('Record allocation timeline'));
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Profiler.ProfileLauncherView = class extends UI.VBox {
this._controlButton.title = this._recordButtonEnabled ? '' : UI.anotherProfilerActiveLabel();
if (this._isInstantProfile) {
this._controlButton.classList.remove('running');
this._controlButton.textContent = Common.UIString('Take Snapshot');
this._controlButton.textContent = Common.UIString('Take snapshot');
} else if (this._isProfiling) {
this._controlButton.classList.add('running');
this._controlButton.textContent = Common.UIString('Stop');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Sources.CallStackSidebarPane = class extends UI.SimpleView {
this.contentElement.appendChild(this._blackboxedMessageElement);

this._notPausedMessageElement = this.contentElement.createChild('div', 'gray-info-message');
this._notPausedMessageElement.textContent = Common.UIString('Not Paused');
this._notPausedMessageElement.textContent = Common.UIString('Not paused');

/** @type {!UI.ListModel<!Sources.CallStackSidebarPane.Item>} */
this._items = new UI.ListModel();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Sources.JavaScriptBreakpointsSidebarPane = class extends UI.ThrottledWidget {
this._listElement = null;
this.contentElement.removeChildren();
var emptyElement = this.contentElement.createChild('div', 'gray-info-message');
emptyElement.textContent = Common.UIString('No Breakpoints');
emptyElement.textContent = Common.UIString('No breakpoints');
this.contentElement.appendChild(emptyElement);
this._didUpdateForTest();
return Promise.resolve();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {
if (!details || !callFrame) {
var infoElement = createElement('div');
infoElement.className = 'gray-info-message';
infoElement.textContent = Common.UIString('Not Paused');
infoElement.textContent = Common.UIString('Not paused');
this.contentElement.appendChild(infoElement);
return;
}
Expand All @@ -78,21 +78,21 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {
switch (scope.type()) {
case Protocol.Debugger.ScopeType.Local:
foundLocalScope = true;
emptyPlaceholder = Common.UIString('No Variables');
emptyPlaceholder = Common.UIString('No variables');
if (thisObject)
extraProperties.push(new SDK.RemoteObjectProperty('this', thisObject));
if (i === 0) {
var exception = details.exception();
if (exception) {
extraProperties.push(new SDK.RemoteObjectProperty(
Common.UIString.capitalize('Exception'), exception, undefined, undefined, undefined, undefined,
undefined, true));
Common.UIString('Exception'), exception, undefined, undefined, undefined, undefined, undefined,
true));
}
var returnValue = callFrame.returnValue();
if (returnValue) {
extraProperties.push(new SDK.RemoteObjectProperty(
Common.UIString.capitalize('Return ^value'), returnValue, undefined, undefined, undefined, undefined,
undefined, true));
Common.UIString('Return value'), returnValue, undefined, undefined, undefined, undefined, undefined,
true));
}
}
break;
Expand All @@ -102,7 +102,7 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {
title = Common.UIString('Closure (%s)', UI.beautifyFunctionName(scopeName));
else
title = Common.UIString('Closure');
emptyPlaceholder = Common.UIString('No Variables');
emptyPlaceholder = Common.UIString('No variables');
break;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ Sources.SnippetsNavigatorView = class extends Sources.NavigatorView {
constructor() {
super();
var toolbar = new UI.Toolbar('navigator-toolbar');
var newButton = new UI.ToolbarButton('', 'largeicon-add', Common.UIString('New Snippet'));
var newButton = new UI.ToolbarButton('', 'largeicon-add', Common.UIString('New snippet'));
newButton.addEventListener(UI.ToolbarButton.Events.Click, this._handleCreateSnippet.bind(this));
toolbar.appendToolbarItem(newButton);
this.element.insertBefore(toolbar.element, this.element.firstChild);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ Sources.SourcesPanel = class extends UI.Panel {
_createDebugToolbarDrawer() {
var debugToolbarDrawer = createElementWithClass('div', 'scripts-debug-toolbar-drawer');

var label = Common.UIString('Pause On Caught Exceptions');
var label = Common.UIString('Pause on caught exceptions');
var setting = Common.moduleSetting('pauseOnCaughtException');
debugToolbarDrawer.appendChild(UI.SettingsUI.createSettingCheckbox(label, setting, true));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Sources.WatchExpressionsSidebarPane = class extends UI.ThrottledWidget {
this.contentElement.removeChildren();
this._watchExpressions = [];
this._emptyElement = this.contentElement.createChild('div', 'gray-info-message');
this._emptyElement.textContent = Common.UIString('No Watch Expressions');
this._emptyElement.textContent = Common.UIString('No watch expressions');
var watchExpressionStrings = this._watchExpressionsSetting.get();
for (var i = 0; i < watchExpressionStrings.length; ++i) {
var expression = watchExpressionStrings[i];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Sources.XHRBreakpointsSidebarPane = class extends UI.VBox {

this._listElement = this.contentElement.createChild('div', 'breakpoint-list hidden');
this._emptyElement = this.contentElement.createChild('div', 'gray-info-message');
this._emptyElement.textContent = Common.UIString('No Breakpoints');
this._emptyElement.textContent = Common.UIString('No breakpoints');

/** @type {!Map.<string, !Element>} */
this._breakpointElements = new Map();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Timeline.TimelinePanel = class extends UI.Panel {
Common.settings.createSetting('timelineViewMode', Timeline.TimelinePanel.ViewMode.FlameChart);

this._disableCaptureJSProfileSetting = Common.settings.createSetting('timelineDisableJSSampling', false);
this._disableCaptureJSProfileSetting.setTitle(Common.UIString('Disable JavaScript Samples'));
this._disableCaptureJSProfileSetting.setTitle(Common.UIString('Disable JavaScript samples'));
this._captureLayersAndPicturesSetting = Common.settings.createSetting('timelineCaptureLayersAndPictures', false);
this._captureLayersAndPicturesSetting.setTitle(Common.UIString('Enable advanced paint instrumentation (slow)'));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ UI.SearchableView = class extends UI.VBox {
this._searchNavigationPrevElement =
searchNavigationElement.createChild('div', 'toolbar-search-navigation toolbar-search-navigation-prev');
this._searchNavigationPrevElement.addEventListener('click', this._onPrevButtonSearch.bind(this), false);
this._searchNavigationPrevElement.title = Common.UIString('Search Previous');
this._searchNavigationPrevElement.title = Common.UIString('Search previous');

this._searchNavigationNextElement =
searchNavigationElement.createChild('div', 'toolbar-search-navigation toolbar-search-navigation-next');
this._searchNavigationNextElement.addEventListener('click', this._onNextButtonSearch.bind(this), false);
this._searchNavigationNextElement.title = Common.UIString('Search Next');
this._searchNavigationNextElement.title = Common.UIString('Search next');

this._searchInputElement.addEventListener('keydown', this._onSearchKeyDown.bind(this), true);
this._searchInputElement.addEventListener('input', this._onInput.bind(this), false);
Expand Down Expand Up @@ -120,7 +120,7 @@ UI.SearchableView = class extends UI.VBox {
this._buttonsContainer.appendChild(this._replaceButtonElement);

var replaceAllButtonElement =
UI.createTextButton(Common.UIString('Replace All'), this._replaceAll.bind(this), 'search-action-button');
UI.createTextButton(Common.UIString('Replace all'), this._replaceAll.bind(this), 'search-action-button');
this._buttonsContainer.appendChild(replaceAllButtonElement);

// Build the replace checkbox and cancel button.
Expand Down

0 comments on commit 47dd4cc

Please sign in to comment.