Add linux-layout-tests-edit-ng try bot

This trybot runs webkit layout tests with editingNGruntime flag set. Bug: 1062919 Change-Id: I7a201213d95f09f5ba857e45df9612a6db3960d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111410 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#752250}
qweri0p · Mar 21, 2020 · 40f79aa · 40f79aa
1 parent aa4a1a4
commit 40f79aa
Show file tree

Hide file tree

Showing 12 changed files with 129 additions and 0 deletions.
diff --git a/infra/config/buckets/try.star b/infra/config/buckets/try.star
@@ -438,6 +438,10 @@ try_.chromium_linux_builder(
     name = 'linux_chromium_ubsan_rel_ng',
 )
 
+try_.chromium_linux_builder(
+    name = 'linux-layout-tests-edit-ng',
+)
+
 try_.chromium_linux_builder(
     name = 'linux-layout-tests-fragment-item',
 )

diff --git a/infra/config/consoles/luci.chromium.try.star b/infra/config/consoles/luci.chromium.try.star
@@ -128,6 +128,7 @@ luci.list_view(
         'try/linux_chromium_tsan_rel_ng',
         'try/linux_chromium_ubsan_rel_ng',
         'try/linux_layout_tests_composite_after_paint',
+        'try/linux-layout-tests-edit-ng',
         'try/linux-layout-tests-fragment-item',
         'try/linux_layout_tests_layout_ng_disabled',
         'try/linux_mojo',

diff --git a/infra/config/consoles/tryserver.chromium.linux.star b/infra/config/consoles/tryserver.chromium.linux.star
@@ -52,6 +52,7 @@ luci.list_view(
         'try/linux_chromium_tsan_rel_ng',
         'try/linux_chromium_ubsan_rel_ng',
         'try/linux_layout_tests_composite_after_paint',
+        'try/linux-layout-tests-edit-ng',
         'try/linux-layout-tests-fragment-item',
         'try/linux_layout_tests_layout_ng_disabled',
         'try/linux_mojo',

diff --git a/infra/config/generated/commit-queue.cfg b/infra/config/generated/commit-queue.cfg
@@ -765,6 +765,10 @@ config_groups: <
         name: "chromium/try/linux-gcc-rel"
         includable_only: true
       >
+      builders: <
+        name: "chromium/try/linux-layout-tests-edit-ng"
+        includable_only: true
+      >
       builders: <
         name: "chromium/try/linux-layout-tests-fragment-item"
         includable_only: true

diff --git a/infra/config/generated/cr-buildbucket.cfg b/infra/config/generated/cr-buildbucket.cfg
@@ -17931,6 +17931,35 @@ buckets: <
         value: 5
       >
     >
+    builders: <
+      name: "linux-layout-tests-edit-ng"
+      swarming_host: "chromium-swarm.appspot.com"
+      swarming_tags: "vpython:native-python-wrapper"
+      dimensions: "builderless:1"
+      dimensions: "cores:8"
+      dimensions: "cpu:x86-64"
+      dimensions: "os:Ubuntu-16.04"
+      dimensions: "ssd:0"
+      recipe: <
+        name: "chromium_trybot"
+        cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
+        cipd_version: "refs/heads/master"
+        properties_j: "$build/goma:{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\"}"
+        properties_j: "$kitchen:{\"devshell\":true,\"git_auth\":true}"
+        properties_j: "mastername:\"tryserver.chromium.linux\""
+      >
+      execution_timeout_secs: 14400
+      expiration_secs: 7200
+      caches: <
+        name: "win_toolchain"
+        path: "win_toolchain"
+      >
+      build_numbers: YES
+      service_account: "chromium-try-builder@chops-service-accounts.iam.gserviceaccount.com"
+      task_template_canary_percentage: <
+        value: 5
+      >
+    >
     builders: <
       name: "linux-layout-tests-fragment-item"
       swarming_host: "chromium-swarm.appspot.com"

diff --git a/infra/config/generated/luci-milo.cfg b/infra/config/generated/luci-milo.cfg
@@ -10286,6 +10286,9 @@ consoles: <
   builders: <
     name: "buildbucket/luci.chromium.try/linux_layout_tests_composite_after_paint"
   >
+  builders: <
+    name: "buildbucket/luci.chromium.try/linux-layout-tests-edit-ng"
+  >
   builders: <
     name: "buildbucket/luci.chromium.try/linux-layout-tests-fragment-item"
   >
@@ -13724,6 +13727,9 @@ consoles: <
   builders: <
     name: "buildbucket/luci.chromium.try/linux_layout_tests_composite_after_paint"
   >
+  builders: <
+    name: "buildbucket/luci.chromium.try/linux-layout-tests-edit-ng"
+  >
   builders: <
     name: "buildbucket/luci.chromium.try/linux-layout-tests-fragment-item"
   >

diff --git a/testing/buildbot/chromium.try.json b/testing/buildbot/chromium.try.json
@@ -184,6 +184,39 @@
       }
     ]
   },
+  "linux-layout-tests-edit-ng": {
+    "additional_compile_targets": [
+      "blink_tests"
+    ],
+    "isolated_scripts": [
+      {
+        "args": [
+          "--num-retries=3",
+          "--additional-driver-flag=--enable-blink-features=EditingNGruntime"
+        ],
+        "isolate_name": "blink_web_tests",
+        "merge": {
+          "args": [
+            "--verbose"
+          ],
+          "script": "//third_party/blink/tools/merge_web_test_results.py"
+        },
+        "name": "blink_web_tests",
+        "results_handler": "layout tests",
+        "swarming": {
+          "can_use_on_swarming_builders": true,
+          "dimension_sets": [
+            {
+              "os": "Ubuntu-16.04"
+            }
+          ],
+          "service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com",
+          "shards": 12
+        },
+        "test_target": "//:blink_web_tests"
+      }
+    ]
+  },
   "linux-layout-tests-fragment-item": {
     "additional_compile_targets": [
       "blink_tests"

diff --git a/testing/buildbot/test_suite_exceptions.pyl b/testing/buildbot/test_suite_exceptions.pyl
@@ -325,6 +325,11 @@
           'shards': 20,
         },
       },
+      'linux-layout-tests-edit-ng': {
+        'args': [
+          '--additional-driver-flag=--enable-blink-features=EditingNGruntime',
+        ],
+      },
       'linux-layout-tests-fragment-item': {
         'args': [
           '--additional-driver-flag=--enable-blink-features=LayoutNGFragmentItem',

diff --git a/testing/buildbot/tryserver.chromium.linux.json b/testing/buildbot/tryserver.chromium.linux.json
@@ -1,6 +1,39 @@
 {
   "AAAAA1 AUTOGENERATED FILE DO NOT EDIT": {},
   "AAAAA2 See generate_buildbot_json.py to make changes": {},
+  "linux-layout-tests-edit-ng": {
+    "additional_compile_targets": [
+      "blink_tests"
+    ],
+    "isolated_scripts": [
+      {
+        "args": [
+          "--num-retries=3",
+          "--additional-driver-flag=--enable-blink-features=EditingNGruntime"
+        ],
+        "isolate_name": "blink_web_tests",
+        "merge": {
+          "args": [
+            "--verbose"
+          ],
+          "script": "//third_party/blink/tools/merge_web_test_results.py"
+        },
+        "name": "blink_web_tests",
+        "results_handler": "layout tests",
+        "swarming": {
+          "can_use_on_swarming_builders": true,
+          "dimension_sets": [
+            {
+              "os": "Ubuntu-16.04"
+            }
+          ],
+          "service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com",
+          "shards": 12
+        },
+        "test_target": "//:blink_web_tests"
+      }
+    ]
+  },
   "linux-layout-tests-fragment-item": {
     "additional_compile_targets": [
       "blink_tests"

diff --git a/testing/buildbot/waterfalls.pyl b/testing/buildbot/waterfalls.pyl
@@ -4918,6 +4918,17 @@
     'name': 'tryserver.chromium.linux',
     'mixins': ['chromium-tester-service-account'],
     'machines': {
+      'linux-layout-tests-edit-ng': {
+        'additional_compile_targets': [
+          'blink_tests',
+        ],
+        'mixins': [
+          'linux-xenial',
+        ],
+        'test_suites': {
+          'isolated_scripts': 'chromium_webkit_isolated_scripts',
+        },
+      },
       'linux-layout-tests-fragment-item': {
         'additional_compile_targets': [
           'blink_tests',

diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
@@ -852,6 +852,7 @@
 
       'linux_layout_tests_composite_after_paint': 'release_trybot',
       'linux_layout_tests_layout_ng_disabled': 'release_trybot',
+      'linux-layout-tests-edit-ng': 'release_trybot',
       'linux-layout-tests-fragment-item': 'release_trybot',
       'linux_mojo': 'release_trybot',
       'linux_mojo_chromeos': 'chromeos_with_codecs_release_trybot',

diff --git a/tools/mb/mb_config_buckets.pyl b/tools/mb/mb_config_buckets.pyl
@@ -1360,6 +1360,7 @@
       'linux-dawn-rel': 'dawn_tests_release_trybot',
       'linux-dcheck-off-rel': 'release_trybot_dcheck_off',
       'linux-gcc-rel': 'release_bot_x86_minimal_symbols_no_clang_cxx11',
+      'linux-layout-tests-edit-ng': 'release_trybot',
       'linux-layout-tests-fragment-item': 'release_trybot',
       'linux-libfuzzer-asan-rel': 'libfuzzer_asan_release_trybot',
       'linux-ozone-rel': 'ozone_linux_release_trybot',