Skip to content

Commit

Permalink
Make roll_harfbuzz.sh work properly on Mac.
Browse files Browse the repository at this point in the history
On Mac `find` by default interprets the first parameter literally as a
directory string and does not normalize the resulting file names the way
`find` does on Linux. Remove the unnecessary trailing '/' so that both
Mac and Linux versions produce the expected output.

Change-Id: I0f06d6025ce7eb545a5fbdab7686403bbebc80b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3384285
Auto-Submit: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#958489}
  • Loading branch information
bungeman authored and Chromium LUCI CQ committed Jan 13, 2022
1 parent 71987cd commit 39d2e3f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion third_party/harfbuzz-ng/roll-harfbuzz.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ check_all_files_are_categorized() {
CDPATH= && cd -- "$(dirname -- "$0")" &&

HB_SOURCE_MISSING=false &&
find src/src/ -type f \( -name "hb-*.cc" -o -name "hb-*.h" -o -name "hb-*.hh" \) | while read HB_SOURCE
find src/src -type f \( -name "hb-*.cc" -o -name "hb-*.h" -o -name "hb-*.hh" \) | while read HB_SOURCE
do
if ! grep -qF "$HB_SOURCE" BUILD.gn; then
if ! ${HB_SOURCE_MISSING}; then
Expand Down

0 comments on commit 39d2e3f

Please sign in to comment.