Increase Max Range for RasterPixelsPerMs

Increase the max ranger to 100M. BUG= R=ericrk CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2498703002 Cr-Commit-Position: refs/heads/master@{#435052}
qweri0p · Nov 29, 2016 · 323ed90 · 323ed90
1 parent 7f51e89
commit 323ed90
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 5 deletions.
diff --git a/cc/base/histograms.h b/cc/base/histograms.h
@@ -64,8 +64,9 @@ const char* GetClientNameForMetrics();
       /* runtime constant. */                                               \
       UMA_HISTOGRAM_COUNTS(base::StringPrintf(time_histogram, client_name), \
                            time_sample);                                    \
-      UMA_HISTOGRAM_COUNTS(base::StringPrintf(area_histogram, client_name), \
-                           area_sample);                                    \
+      UMA_HISTOGRAM_CUSTOM_COUNTS(                                          \
+          base::StringPrintf(area_histogram, client_name), area_sample, 1,  \
+          100000000, 50);                                                   \
     }                                                                       \
   }
 

diff --git a/cc/tiles/tile_manager.cc b/cc/tiles/tile_manager.cc
@@ -43,17 +43,17 @@ const bool kUseColorEstimator = true;
 DEFINE_SCOPED_UMA_HISTOGRAM_AREA_TIMER(
     ScopedGeneralRasterTaskTimer,
     "Compositing.%s.RasterTask.RasterUs",
-    "Compositing.%s.RasterTask.RasterPixelsPerMs");
+    "Compositing.%s.RasterTask.RasterPixelsPerMs2");
 
 DEFINE_SCOPED_UMA_HISTOGRAM_AREA_TIMER(
     ScopedSoftwareRasterTaskTimer,
     "Compositing.%s.RasterTask.RasterUs.Software",
-    "Compositing.%s.RasterTask.RasterPixelsPerMs.Software");
+    "Compositing.%s.RasterTask.RasterPixelsPerMs2.Software");
 
 DEFINE_SCOPED_UMA_HISTOGRAM_AREA_TIMER(
     ScopedGpuRasterTaskTimer,
     "Compositing.%s.RasterTask.RasterUs.Gpu",
-    "Compositing.%s.RasterTask.RasterPixelsPerMs.Gpu");
+    "Compositing.%s.RasterTask.RasterPixelsPerMs2.Gpu");
 
 class ScopedRasterTaskTimer {
  public:

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
@@ -6619,6 +6619,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 
 <histogram name="Compositing.Browser.RasterTask.RasterPixelsPerMs"
     units="pixels/ms">
+  <obsolete>
+    Deprecated 11/2016. Increased the max tracking range to accomendate GPU
+    raster, and will require new baskets.
+  </obsolete>
+  <owner>paint-dev@chromium.org</owner>
+  <summary>
+    Rasterized area, in pixels, divided by rasterization time, in milliseconds,
+    of a compositor rasterization task. Recorded after the task finishes (in a
+    browser process).
+  </summary>
+</histogram>
+
+<histogram name="Compositing.Browser.RasterTask.RasterPixelsPerMs2"
+    units="pixels/ms">
   <owner>paint-dev@chromium.org</owner>
   <summary>
     Rasterized area, in pixels, divided by rasterization time, in milliseconds,
@@ -6870,6 +6884,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 
 <histogram name="Compositing.Renderer.RasterTask.RasterPixelsPerMs"
     units="pixels/ms">
+  <obsolete>
+    Deprecated 11/2016. Increased the max tracking range to accomendate GPU
+    raster, and will require new baskets.
+  </obsolete>
+  <owner>paint-dev@chromium.org</owner>
+  <summary>
+    Rasterized area, in pixels, divided by rasterization time, in milliseconds,
+    of a compositor rasterization task. Recorded after the task finishes (in a
+    renderer process).
+  </summary>
+</histogram>
+
+<histogram name="Compositing.Renderer.RasterTask.RasterPixelsPerMs2"
+    units="pixels/ms">
   <owner>paint-dev@chromium.org</owner>
   <summary>
     Rasterized area, in pixels, divided by rasterization time, in milliseconds,
@@ -111961,8 +111989,11 @@ value.
   <suffix name="Gpu" label="This metric is for only gpu raster."/>
   <suffix name="Software" label="This metric is for only software raster."/>
   <affected-histogram name="Compositing.Browser.RasterTask.RasterPixelsPerMs"/>
+  <affected-histogram name="Compositing.Browser.RasterTask.RasterPixelsPerMs2"/>
   <affected-histogram name="Compositing.Browser.RasterTask.RasterUs"/>
   <affected-histogram name="Compositing.Renderer.RasterTask.RasterPixelsPerMs"/>
+  <affected-histogram
+      name="Compositing.Renderer.RasterTask.RasterPixelsPerMs2"/>
   <affected-histogram name="Compositing.Renderer.RasterTask.RasterUs"/>
   <affected-histogram name="Renderer4.ImageDecodeTaskDurationUs"/>
 </histogram_suffixes>