Skip to content

Commit

Permalink
Add WeakRef and FinalizationRegistry to the list of JS builtins for t…
Browse files Browse the repository at this point in the history
…ests

Bug: chromium:1016767
Change-Id: I60f3e8ad38a70fc9b76f582a3a7e0bca5f5ada37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160020
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#761550}
  • Loading branch information
syg authored and Commit Bot committed Apr 22, 2020
1 parent d9fc0bf commit 2e870ed
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var globals = [];
// List of builtin JS constructors; Blink is not controlling what properties these
// objects have, so exercising them in a Blink test doesn't make sense.
//
// This list should be kept in sync with the one at LayoutTests/resources/global-interface-listing.js
// This list should be kept in sync with the one at web_tests/resources/global-interface-listing.js
var js_builtins = new Set([
'Array',
'ArrayBuffer',
Expand All @@ -30,6 +30,7 @@ var js_builtins = new Set([
'Date',
'Error',
'EvalError',
'FinalizationRegistry',
'Float32Array',
'Float64Array',
'Function',
Expand Down Expand Up @@ -62,6 +63,7 @@ var js_builtins = new Set([
'Uint8Array',
'Uint8ClampedArray',
'WeakMap',
'WeakRef',
'WeakSet',
'WebAssembly',
'decodeURI',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function globalInterfaceListing(globalObject, propertyNamesInGlobal, platformSpe
// objects have, so exercising them in a Blink test doesn't make sense.
//
// If new builtins are added, please update this list along with the one in
// LayoutTests/http/tests/worklet/webexposed/resources/global-interface-listing-worklet.js
// web_tests/http/tests/worklet/webexposed/resources/global-interface-listing-worklet.js
var jsBuiltins = new Set([
'Array',
'ArrayBuffer',
Expand All @@ -26,6 +26,7 @@ var jsBuiltins = new Set([
'Date',
'Error',
'EvalError',
'FinalizationRegistry',
'Float32Array',
'Float64Array',
'Function',
Expand Down Expand Up @@ -58,6 +59,7 @@ var jsBuiltins = new Set([
'Uint8Array',
'Uint8ClampedArray',
'WeakMap',
'WeakRef',
'WeakSet',
'WebAssembly',
'decodeURI',
Expand Down

0 comments on commit 2e870ed

Please sign in to comment.