Skip to content

Commit

Permalink
disable_chromium_framebuffer_multisample on old Qualcomm drivers
Browse files Browse the repository at this point in the history
Specifically this bug was seen on Adreno 405 on Lollipop. It turns out
that the older driver has a bug that's not covered by the fix in
https://crrev.com/c/520883 . Since this is such an old device it's not
worth it to find a workaround, instead we just re-disable multisampling
and WebGL 2.0 which were enabled in that patch.

Bug: 767913
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I661c974a617bec35eeb830fd1dffd28c0be5f7f2
Reviewed-on: https://chromium-review.googlesource.com/727182
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509958}
  • Loading branch information
kainino0x authored and Commit Bot committed Oct 19, 2017
1 parent 34eeae6 commit 2b771f5
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 3 deletions.
8 changes: 6 additions & 2 deletions gpu/config/gpu_driver_bug_list.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gpu driver bug list",
"version": "10.32",
"version": "10.33",
"entries": [
{
"id": 1,
Expand Down Expand Up @@ -1046,7 +1046,8 @@
{
"id": 116,
"description": "Adreno 420 support for EXT_multisampled_render_to_texture is buggy on Android < 5.1",
"cr_bugs": [490379],
"comment": "Corresponds to software rendering list #149",
"cr_bugs": [490379, 767913],
"os": {
"type": "android",
"version": {
Expand All @@ -1057,6 +1058,9 @@
"gl_renderer": "Adreno \\(TM\\) 4.*",
"disabled_extensions": [
"GL_EXT_multisampled_render_to_texture"
],
"features": [
"disable_chromium_framebuffer_multisample"
]
},
{
Expand Down
19 changes: 18 additions & 1 deletion gpu/config/software_rendering_list.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "software rendering list",
"version": "13.12",
"version": "13.13",
"entries": [
{
"id": 1,
Expand Down Expand Up @@ -1538,6 +1538,23 @@
"features": [
"gpu_rasterization"
]
},
{
"id": 149,
"description": "Adreno 420 support for EXT_multisampled_render_to_texture is buggy on Android < 5.1",
"comment": "Corresponds to GPU driver bug #116",
"cr_bugs": [490379, 767913],
"os": {
"type": "android",
"version": {
"op": "<",
"value": "5.1"
}
},
"gl_renderer": "Adreno \\(TM\\) 4.*",
"features": [
"accelerated_webgl2"
]
}
],
"comment": [
Expand Down

0 comments on commit 2b771f5

Please sign in to comment.