Skip to content

Commit

Permalink
Revert 202729 "chrome/browser: Remove unnecessary entries from D..."
Browse files Browse the repository at this point in the history
This breaks 'git cl upload'.

> chrome/browser: Remove unnecessary entries from DEPS files.
> 
> After recent refactorings chrome/browser/api and a few chrome/browser/profiles/
> includes are not necessary anymore. c/b/api was removed in r195919 by Peter and
> some c/b/profiles/ were moved in r201167 by Pawel.
> 
> BUG=138280,144783, 140037, 144050, 146851, 233552
> TEST=checkdeps.py passes.
> R=joi@chromium.org, thestig@chromium.org
> 
> Review URL: https://codereview.chromium.org/16072002

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/15974007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202748 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
akalin@chromium.org committed May 29, 2013
1 parent 5a49a6a commit 2a38f0c
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 5 deletions.
7 changes: 4 additions & 3 deletions WATCHLISTS
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
'filepath': 'ui/aura/|'\
'ash/',
},
'autofill': { 'chrome/browser/autofill/|'\
'autofill': {
'filepath': 'chrome/browser/api/webdata/|'\
'chrome/browser/autofill/|'\
'chrome/browser/resources/options/autofill_|'\
'chrome/browser/sync/glue/autofill_|'\
'chrome/browser/ui/android/autofill/|'\
Expand All @@ -55,11 +57,10 @@
'chrome/browser/ui/gtk/autofill/|'\
'chrome/browser/ui/views/autofill/|'\
'chrome/browser/ui/webui/options/autofill_|'\
'chrome/browser/webdata/|'\
'chrome/renderer/autofill/|'\
'chrome/test/data/autofill/|'\
'components/autofill/|'\
'components/autofill/browser/webdata/|'\
'components/webdata/|'\
'content/public/common/password_|'\
'content/public/renderer/password_|'\
'content/renderer/password_',
Expand Down
3 changes: 2 additions & 1 deletion chrome/browser/common/DEPS
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
include_rules = [
# Common is for library/utility code shared by multiple parts of chrome
# browser. It should not depend on other parts of the browser.
# browser. So it should not depend on other parts of the browser except API.
"-chrome/browser",
"+chrome/browser/api",
"+chrome/browser/common",
]
3 changes: 2 additions & 1 deletion chrome/browser/common/README
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
This directory contains library/utility code shared by multiple Browser
Components. It should not depend on other parts of the browser.
Components. It should not depend on other parts of the browser except through
api(chrome/browser/api).
1 change: 1 addition & 0 deletions chrome/browser/favicon/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# three basic rules followed by temporary exceptions. Please don't
# add to the list of exceptions!
"-chrome/browser",
"+chrome/browser/api",
"+chrome/browser/common",
"+chrome/browser/favicon",

Expand Down
1 change: 1 addition & 0 deletions chrome/browser/history/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ include_rules = [
# basic rules followed by temporary exceptions. Please don't
# add to the list of exceptions!
"-chrome/browser",
"+chrome/browser/api",
"+chrome/browser/common",
"+chrome/browser/favicon",
"+chrome/browser/history",
Expand Down
2 changes: 2 additions & 0 deletions components/autofill/browser/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ specific_include_rules = {
#
# Do not add to the list of temporarily-allowed dependencies below,
# and please do not introduce more #includes of these files.
"!chrome/browser/api/infobars/confirm_infobar_delegate.h",
"!chrome/browser/api/infobars/infobar_service.h",
"!chrome/browser/autofill/autofill_cc_infobar_delegate.h",
"!chrome/browser/autofill/personal_data_manager_factory.h",
"!chrome/browser/password_manager/encryptor.h",
Expand Down

0 comments on commit 2a38f0c

Please sign in to comment.