Skip to content

Commit

Permalink
Revert "[Tracing] Use Perfetto client library for tracing on Android"
Browse files Browse the repository at this point in the history
This reverts commit 915cca4.

Reason for revert: Potential culprit for Trace-related test failing
on Android. See crbug.com/1471763.

Original change's description:
> [Tracing] Use Perfetto client library for tracing on Android
>
> This CL switches the Chrome tracing backend to Perfetto client
> library. It means that Chrome on Android will use a different set of
> TRACE_EVENT* macros that call Perfetto client API under the hood.
>
> The Perfetto backend has been the default on desktop Linux since
> March. Now we make it the default on Android too. Our end goal is to
> make Perfetto the default backend on all platforms, unblocking
> multiple improvements in tracing stability and usefulness.
>
> Significant effort has been made to make the binary size impact as
> small as possible, but some overhead remains. See this thread:
> https://groups.google.com/a/google.com/d/msgid/woa-performance-team/CABiQX1XriNOZcYRBtO2JWq2Uzqbgjh_4ZMuXXaPJUdp%3DvkTZ-g%40mail.gmail.com
> for more info and discussion.
>
> Binary-Size: See above.
> Bug: 1006541
> Change-Id: Ia6ab96a6f3402f446fefab872c41686f480c2ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4701264
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
> Cr-Commit-Position: refs/heads/main@{#1181499}

Bug: 1006541, 1471763
Change-Id: Ie6fdcc99ec777c81fd1b006ecb9a583603eefe30
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767556
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Owners-Override: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1181768}
  • Loading branch information
Yue Zhang authored and Chromium LUCI CQ committed Aug 9, 2023
1 parent d404c06 commit 29bcf9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build_overrides/build.gni
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ declare_args() {
# Switches the TRACE_EVENT instrumentation from base's TraceLog implementation
# to //third_party/perfetto's client library.
# TODO(crbug/1006541): Switch to perfetto's client library on all platforms.
use_perfetto_client_library = (is_linux || is_android) && !is_castos
use_perfetto_client_library = is_linux && !is_castos

# Limits the defined //third_party/android_deps targets to only "buildCompile"
# and "buildCompileNoDeps" targets. This is useful for third-party
Expand Down

0 comments on commit 29bcf9e

Please sign in to comment.