WebUI: Update @typescript-eslint/{eslint-plugin,parser} to v6.7.4.

This is a necessary preparatory step for updating TypeScript to v5.2 in
a follow-up CL.

The new version has moved the location of the main binary, from
node_modules/@typescript-eslint/parser to
node_modules/@typescript-eslint/parser/dist/index.js.

Updated to the new path in several .eslintrc.js files.

Moreover, with the newer version several new errors in
ash/webui/camera_app_ui/ had to be fixed/suppressed.
 - Updated eslint-plugin-jsdoc from v37.5.1 to v46.8.2 to fix
   internal errors when running ESLint.
 - Replaced @typescript-eslint/sort-type-union-intersection-members
   with @typescript-eslint/sort-type-constituents (rule was renamed).
 - Removed jsdoc/newline-after-description rule (no longer exists)
 - Moved @typescript-eslint/prefer-optional-chain as needed in the
   .eslintrc.js file, since it now requires `parserOptions.project`
   to be specified for it to work.
 - Updated jsdoc/tag-lines rule definition, as needed to fix new
   errors (default spec for that rule seem to has changed)
 - Fixed newly found @typescript-eslint/prefer-nullish-coalescing
   violation.

(Some ash/webui/camera_app_ui/ fixes provided by pihsun@)

Bug: 1488690,b/303328674
Change-Id: I6667118a490b9177486d3cf90934ee43292eb1b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4910239
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1205440}

.eslintrc.js

@@ -81,7 +81,7 @@ module.exports = {
 
   'overrides': [{
     'files': ['**/*.ts'],
-    'parser': './third_party/node/node_modules/@typescript-eslint/parser',
+    'parser': './third_party/node/node_modules/@typescript-eslint/parser/dist/index.js',
     'plugins': [
       '@typescript-eslint',
     ],

ash/webui/camera_app_ui/resources/.eslintrc.js

@@ -413,7 +413,7 @@ module.exports = {
       },
     },
   },
-  parser: `${typescriptEslintDir}/parser`,
+  parser: `${typescriptEslintDir}/parser/dist/index.js`,
   plugins: ['@typescript-eslint', 'jsdoc', 'eslint-plugin-cca'],
   // Generally, the rules should be compatible to both bundled and the newest
   // stable eslint, so it's easier to upgrade and develop without the full
@@ -696,9 +696,7 @@ module.exports = {
       },
     ],
 
-    '@typescript-eslint/prefer-optional-chain': 'error',
-
-    '@typescript-eslint/sort-type-union-intersection-members': 'error',
+    '@typescript-eslint/sort-type-constituents': 'error',
 
     'comma-dangle': 'off',
     '@typescript-eslint/comma-dangle': ['error', 'always-multiline'],
@@ -748,7 +746,6 @@ module.exports = {
     'jsdoc/check-values': 'error',
     'jsdoc/empty-tags': 'error',
     'jsdoc/implements-on-classes': 'error',
-    'jsdoc/newline-after-description': 'error',
     'jsdoc/no-undefined-types': 'error',
     'jsdoc/require-param-description': 'error',
     'jsdoc/require-param-name': 'error',
@@ -759,7 +756,7 @@ module.exports = {
     'jsdoc/require-returns-check': 'error',
     'jsdoc/require-returns-description': 'error',
     'jsdoc/require-yields-check': 'error',
-    'jsdoc/tag-lines': 'error',
+    'jsdoc/tag-lines': ['error', 'never', {startLines: 1}],
     'jsdoc/valid-types': 'error',
 
     'no-invalid-this': 'off',
@@ -782,6 +779,8 @@ module.exports = {
 
       '@typescript-eslint/prefer-nullish-coalescing': 'error',
 
+      '@typescript-eslint/prefer-optional-chain': 'error',
+
       // go/tsstyle#optimization-compatibility-for-property-access
       '@typescript-eslint/dot-notation': 'error',
 

ash/webui/camera_app_ui/resources/js/models/lazy_directory_entry.ts

@@ -19,8 +19,7 @@ export async function getMaybeLazyDirectory(
     name: string): Promise<DirectoryAccessEntry> {
   const targetDir =
       await parentDir.getDirectory({name, createIfNotExist: false});
-  return targetDir !== null ? targetDir :
-                              new LazyDirectoryEntry(parentDir, name);
+  return targetDir ?? new LazyDirectoryEntry(parentDir, name);
 }
 
 /**

ash/webui/diagnostics_ui/resources/.eslintrc.js

@@ -12,7 +12,7 @@ module.exports = {
     'overrides': [{
       'files': ['**/*.ts'],
       'parser':
-        '../../../../third_party/node/node_modules/@typescript-eslint/parser',
+        '../../../../third_party/node/node_modules/@typescript-eslint/parser/dist/index.js',
       'parserOptions': {
         tsconfigRootDir: __dirname,
       },
@@ -30,4 +30,4 @@ module.exports = {
       },
     }],
   };
-// clang-format on
+// clang-format on

ash/webui/print_management/resources/.eslintrc.js

@@ -11,7 +11,7 @@ module.exports = {
   'overrides': [{
     'files': ['**/*.ts'],
     'parser':
-      '../../../../third_party/node/node_modules/@typescript-eslint/parser',
+      '../../../../third_party/node/node_modules/@typescript-eslint/parser/dist/index.js',
     'parserOptions': {
       tsconfigRootDir: __dirname,
     },
@@ -29,4 +29,4 @@ module.exports = {
     },
   }],
 };
-// clang-format on
+// clang-format on

ash/webui/shortcut_customization_ui/resources/.eslintrc.js

@@ -11,7 +11,7 @@ module.exports = {
     'overrides': [{
       'files': ['**/*.ts'],
       'parser':
-        '../../../../third_party/node/node_modules/@typescript-eslint/parser',
+        '../../../../third_party/node/node_modules/@typescript-eslint/parser/dist/index.js',
       'parserOptions': {
         tsconfigRootDir: __dirname,
       },
@@ -29,4 +29,4 @@ module.exports = {
       },
     }],
   };
-// clang-format on
+// clang-format on

chrome/test/data/pdf/.eslintrc.js

@@ -11,7 +11,7 @@ module.exports = {
 
   'overrides': [{
     'files': ['**/*.ts'],
-    'parser': '../../../../third_party/node/node_modules/@typescript-eslint/parser',
+    'parser': '../../../../third_party/node/node_modules/@typescript-eslint/parser/dist/index.js',
     'plugins': [
       '@typescript-eslint',
     ],

third_party/node/node_modules.tar.gz.sha1

@@ -1 +1 @@
-ddc7cddc319ae5689ebf2c927e284814f2892e47
+8fe0f8ea6861e4629e91aca59ea581f96a33fb91