Skip to content

Commit

Permalink
Crash Chrome with Rust Again
Browse files Browse the repository at this point in the history
Oops, I did it again. When I removed the last platform condition, the
enable_rust_crash became gated on enable_all_rust_features, but that
was only meant to override the disabled platforms.

Bug: 1457505, 1368726
Change-Id: I774116d118eef6c5429149205e6fded1023a05a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718489
Auto-Submit: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175121}
  • Loading branch information
danakj authored and Chromium LUCI CQ committed Jul 25, 2023
1 parent 31d9bdb commit 1b7c18c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/config/rust.gni
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ declare_args() {
enable_rust_json = enable_rust && enable_all_rust_features

# Support for chrome://crash-rust to check crash dump collection works.
enable_rust_crash = enable_rust && enable_all_rust_features
enable_rust_crash = enable_rust

# Support for QR code generation - see https://crbug.com/1431991.
#
Expand Down

0 comments on commit 1b7c18c

Please sign in to comment.