forked from Pissandshittium/pissandshittium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
These tests are periodically failing because a newline has been added to the 'textContent' of a frame. This seems to be because of asynchronicity in when the frame's 'load' event triggers (either the next line has been parsed, or it hasn't). This patch avoids the problem by trimming the string before comparing it to the expected string. BUG=316380 Review URL: https://codereview.chromium.org/91363003 git-svn-id: svn://svn.chromium.org/blink/trunk@163260 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- Loading branch information
mkwst@chromium.org
committed
Dec 5, 2013
1 parent
d33f162
commit 1a19345
Showing
29 changed files
with
28 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-form-get-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-form-get-named-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-form-get-override-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-form-post-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-form-post-named-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-form-post-override-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-hyperlink-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-hyperlink-named-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-hyperlink-override-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-window-location-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
2 changes: 1 addition & 1 deletion
2
..._party/WebKit/LayoutTests/fast/frames/seamless/seamless-window-location-href-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...rty/WebKit/LayoutTests/fast/frames/seamless/seamless-window-location-replace-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
third_party/WebKit/LayoutTests/fast/frames/seamless/seamless-window-open-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].document.body.textContent.trim() is "DONE" | ||
|
2 changes: 1 addition & 1 deletion
2
..._party/WebKit/LayoutTests/fast/frames/seamless/seamless-window-open-override-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
PASS frames[0].frames[0].document.body.textContent is "DONE\n" | ||
PASS frames[0].frames[0].document.body.textContent.trim() is "DONE" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters