Remove V8Future experiment.

Removes the V8 Future experiment since it conflicts with the V8NoTurbo experiment and adds confusion as to how to enable / disable Ignition+ TurboFan. Also make the description for the V8NoTurbo about://flags entry clearer. BUG=chromium:703569,chromium:705476 Review-Url: https://codereview.chromium.org/2786633002 Cr-Commit-Position: refs/heads/master@{#460380}
qweri0p · Mar 29, 2017 · 124254a · 124254a
1 parent 8f6e0b4
commit 124254a
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 21 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -951,9 +951,6 @@ const FeatureEntry kFeatureEntries[] = {
     {"shared-array-buffer", flag_descriptions::kEnableSharedArrayBufferName,
      flag_descriptions::kEnableSharedArrayBufferDescription, kOsAll,
      FEATURE_VALUE_TYPE(features::kSharedArrayBuffer)},
-    {"enable-v8-future", flag_descriptions::kV8FutureName,
-     flag_descriptions::kV8FutureDescription, kOsAll,
-     FEATURE_VALUE_TYPE(features::kV8Future)},
     {"disable-v8-ignition-turbo",
      flag_descriptions::kV8DisableIgnitionTurboName,
      flag_descriptions::kV8DisableIgnitionTurboDescription, kOsAll,

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -753,17 +753,12 @@ const char kJavascriptHarmonyName[] = "Experimental JavaScript";
 const char kJavascriptHarmonyDescription[] =
     "Enable web pages to use experimental JavaScript features.";
 
-const char kV8FutureName[] = "Experimental Features in V8 JavaScript execution";
-
-const char kV8FutureDescription[] =
-    "Enable experimental features in V8 for JavaScript execution.";
-
 const char kV8DisableIgnitionTurboName[] =
-    "Disable the new JavaScript Compilation Pipeline";
+    "Classic JavaScript Compilation Pipeline";
 
 const char kV8DisableIgnitionTurboDescription[] =
-    "Disable V8's new Ignition interpreter and TurboFan compiler for "
-    "JavaScript execution.";
+    "Enables V8's classic compilation pipeline for JavaScript execution "
+    "(disabling V8's new Ignition interpreter and TurboFan compiler)";
 
 const char kEnableAsmWasmName[] =
     "Experimental Validate Asm.js and convert to WebAssembly when valid.";

diff --git a/gin/gin_features.cc b/gin/gin_features.cc
@@ -6,11 +6,6 @@
 
 namespace features {
 
-// Enables future experimental features of V8.
-const base::Feature kV8Future {
-  "V8Future", base::FEATURE_DISABLED_BY_DEFAULT
-};
-
 // Disables the new compiler pipeline of V8, with the Ignition interpreter and
 // TurboFan compiler.
 const base::Feature kV8NoTurbo{"V8NoTurbo", base::FEATURE_DISABLED_BY_DEFAULT};

diff --git a/gin/public/gin_features.h b/gin/public/gin_features.h
@@ -13,7 +13,6 @@
 
 namespace features {
 
-GIN_EXPORT extern const base::Feature kV8Future;
 GIN_EXPORT extern const base::Feature kV8NoTurbo;
 GIN_EXPORT extern const base::Feature kV8IgnitionLowEnd;
 

diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
@@ -371,10 +371,6 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode,
     ignition_enabled_crash_key = "N";
     std::string flag("--no-turbo");
     v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
-  } else if (base::FeatureList::IsEnabled(features::kV8Future)) {
-    ignition_enabled_crash_key = "Y";
-    std::string flag("--future");
-    v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
   } else if (base::FeatureList::IsEnabled(features::kV8IgnitionLowEnd) &&
              base::SysInfo::IsLowEndDevice()) {
     ignition_enabled_crash_key = "Y";