[flags] Remove --harmony-string-is-well-formed

The String.prototype.isWellFormed and toWellFormed have shipped since M111. Bug: v8:13557 Change-Id: Ic956395585db6902d8cdb7e80d221e7cd8cbea40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935151 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1211385}
qweri0p · Oct 18, 2023 · 1156648 · 1156648
1 parent 2069a0d
commit 1156648
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 9 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -255,6 +255,7 @@ Charles Vaughn <cvaughn@gmail.com>
 Cheng Zhao <zcbenz@gmail.com>
 Cheng Yu <yuzichengcode@gmail.com>
 Chenguang Shao <chenguangshao1@gmail.com>
+Chengzhong Wu <legendecas@gmail.com>
 Choongwoo Han <cwhan.tunz@gmail.com>
 Choudhury M. Shamsujjoha <choudhury.s@samsung.com>
 Chris Dalton <chris@rive.app>

diff --git a/gin/gin_features.cc b/gin/gin_features.cc
@@ -208,11 +208,6 @@ BASE_FEATURE(kJavaScriptRabGsab,
              "JavaScriptRabGsab",
              base::FEATURE_ENABLED_BY_DEFAULT);
 
-// Enables the well-formed JavaScript strings proposal.
-BASE_FEATURE(kJavaScriptStringIsWellFormed,
-             "JavaScriptStringIsWellFormed",
-             base::FEATURE_ENABLED_BY_DEFAULT);
-
 // Enables the JavaScript RegExp Unicode set notation proposal.
 BASE_FEATURE(kJavaScriptRegExpUnicodeSets,
              "JavaScriptRegExpUnicodeSets",

diff --git a/gin/gin_features.h b/gin/gin_features.h
@@ -60,7 +60,6 @@ GIN_EXPORT extern const base::FeatureParam<base::TimeDelta>
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptChangeArrayByCopy);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptRabGsab);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptRegExpUnicodeSets);
-GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptStringIsWellFormed);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptSymbolAsWeakMapKey);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptJsonParseWithSource);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptArrayBufferTransfer);

diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
@@ -373,9 +373,6 @@ void SetFlags(IsolateHolder::ScriptMode mode,
   } else {
     SetV8Flags("--no-harmony-rab-gsab");
   }
-  SetV8FlagsIfOverridden(features::kJavaScriptStringIsWellFormed,
-                         "--harmony-string-is-well-formed",
-                         "--no-harmony-string-is-well-formed");
   SetV8FlagsIfOverridden(features::kJavaScriptRegExpUnicodeSets,
                          "--harmony-regexp-unicode-sets",
                          "--no-harmony-regexp-unicode-sets");