Skip to content

Commit

Permalink
Android: Update android_deps roll README
Browse files Browse the repository at this point in the history
Including warning and mitigation for errors.

Bug: 877956
Change-Id: Id0abfce282d6f3a15ee5a9d4a70751839f2946a2
Reviewed-on: https://chromium-review.googlesource.com/c/1294592
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601705}
  • Loading branch information
Peter Wen authored and Commit Bot committed Oct 22, 2018
1 parent cd57478 commit 05c6009
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tools/android/roll/android_deps/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,20 @@ Full steps to add a new third party library:
- Before running this command, make sure to increment the `CIPD_SUFFIX`
variable in `BuildConfigGenerator.groovy` in order to ensure that each
tag in CIPD is unique.
- One option to thoroughly test your change is to run
`rm -rf third_party/android_deps/libs/[!O]*` before running with
`--update-all`. This will ensure all your deps are fresh. The commands
printed out in the following step will ensure you do not upload
duplicate instances.

4. Run the commands printed at step 3 to create new and updated packages
via cipd.
- In order to do this, you will need write access. Ask anyone from this
[list][owners_link] to add you to the group.
- Just make sure to copy the commands exactly, as uploading an instance
with the same package and tag as an existing instance currently in use
can break all builds, and there is no easy way to delete an instance.
- If this happens, file an infra-trooper bug immediately.

5. Create a commit & follow [`//docs/adding_to_third_party.md`][docs_link] for
the review.
Expand All @@ -57,6 +68,7 @@ file that they use, explained in the [README.chromium][readme_chromium_link] is
up-to-date with the one on android's [website][android_sdk_link], last updated
date is at the bottom.

[owners_link]: http://go/android-deps-owners
[docs_link]: ../../../../docs/adding_to_third_party.md
[android_sdk_link]: https://developer.android.com/studio/terms
[readme_chromium_link]: ../../../../third_party/android_deps/README.chromium
Expand Down

0 comments on commit 05c6009

Please sign in to comment.