Skip to content

Refactor/fancy progressbar notebook detection #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 27, 2021

Conversation

thangleiter
Copy link
Member

#49

Switch to external dependency to get the notebook name. Simplifies code maintenance.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #50 (3d87227) into master (6f8c5c5) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   96.28%   96.96%   +0.67%     
==========================================
  Files           9        9              
  Lines        2100     2074      -26     
  Branches      477      474       -3     
==========================================
- Hits         2022     2011      -11     
+ Misses         41       26      -15     
  Partials       37       37              
Impacted Files Coverage Δ
filter_functions/util.py 97.58% <100.00%> (+5.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f8c5c5...3d87227. Read the comment docs.

@thangleiter thangleiter merged commit aabeb0d into master Feb 27, 2021
@thangleiter thangleiter deleted the refactor/fancy_progressbar_notebook_detection branch February 27, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant