-
Notifications
You must be signed in to change notification settings - Fork 8
Second order magnus #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….de/tobias.hangleiter/python-filter_functions into feature/second_order_magnus
…ontrol_matrix_from_scratch
…ors in time domain
…the same to the PulseSequence interface
Also: - use more meaningful names - don't use zeros_like, empty_like
….de/tobias.hangleiter/python-filter_functions into feature/second_order_magnus
…r_functions into feature/second_order_magnus
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 96.88% 97.21% +0.32%
==========================================
Files 9 9
Lines 2084 2187 +103
Branches 483 502 +19
==========================================
+ Hits 2019 2126 +107
+ Misses 27 25 -2
+ Partials 38 36 -2
Continue to review full report at Codecov.
|
Doesn't make much sense since we cannot factor the second order filter function into control matrices as in the first order case. In princinple, one can still loop the integration over one basis axis, but this is a bit tedious and not pretty to implement, so we leave it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to compute the second order of the Magnus expansion, allowing exact results for the quantum process for Gaussian noise.