Handling list of DICOM datasets reference when creating rtstruct#104
Open
gacou54 wants to merge 1 commit intoqurit:mainfrom
Open
Handling list of DICOM datasets reference when creating rtstruct#104gacou54 wants to merge 1 commit intoqurit:mainfrom
gacou54 wants to merge 1 commit intoqurit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We plan to use
rt-utilsin our pipeline to create RTStruct. Our problem is that the reference DICOM data need to be on the filesystem. For situations where we only manipulate data in memory, I thinkcreate_new()andcreate_from()should be able to take aList[pydicom.Dataset].I modified the signature of these two functions and added/adapted the tests.
I hope the PR is OK and "fits" in
rt-utils. Otherwise, do not hesitate to suggest changes.