Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting images only #132

Merged
merged 16 commits into from
Sep 20, 2024
Merged

Extracting images only #132

merged 16 commits into from
Sep 20, 2024

Conversation

michalbubula
Copy link
Collaborator

No description provided.

@vahidrezanezhad vahidrezanezhad marked this pull request as ready for review September 3, 2024 08:40
Copy link
Member

@cneud cneud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vahidrezanezhad, LGTM for merge now!

Copy link
Contributor

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least for the tests passing, haven't checked the actual code yet.

Copy link
Member

@cneud cneud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these steps are still required:

  1. Update README.md to document the added functionality
  2. New model eynollah-main-regions_20231127_672_org_ens_11_13_16_17_18?
    In this case, the model must be published first, model archives and ocrd-tool.json updated etc. according to our guidelines.

src/eynollah/eynollah.py Show resolved Hide resolved
@cneud cneud self-requested a review September 19, 2024 15:05
@cneud cneud merged commit 4af0bc0 into main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants