-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting images only #132
Conversation
# Conflicts: # src/eynollah/eynollah.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vahidrezanezhad, LGTM for merge now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, at least for the tests passing, haven't checked the actual code yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these steps are still required:
- Update README.md to document the added functionality
- New model
eynollah-main-regions_20231127_672_org_ens_11_13_16_17_18
?
In this case, the model must be published first, model archives andocrd-tool.json
updated etc. according to our guidelines.
No description provided.