Skip to content

Commit

Permalink
Avatar::get(): rename the parameters
Browse files Browse the repository at this point in the history
...the other way around, after code review.
  • Loading branch information
KitsuneRal committed Nov 6, 2024
1 parent c64c900 commit 4dc69ce
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Quotient/avatar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ QImage Avatar::get(int dimension, get_callback_t callback) const
return d->get({ dimension, dimension }, std::move(callback));
}

QImage Avatar::get(int w, int h, get_callback_t callback) const
QImage Avatar::get(int width, int height, get_callback_t callback) const
{
return d->get({ w, h }, std::move(callback));
return d->get({ width, height }, std::move(callback));
}

bool Avatar::upload(const QString& fileName, upload_callback_t callback) const
Expand Down
2 changes: 1 addition & 1 deletion Quotient/avatar.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class QUOTIENT_API Avatar {


QImage get(int dimension, get_callback_t callback) const;
QImage get(int w, int h, get_callback_t callback) const;
QImage get(int width, int height, get_callback_t callback) const;

[[deprecated("Use the QFuture-returning overload instead")]]
bool upload(const QString& fileName, upload_callback_t callback) const;
Expand Down

0 comments on commit 4dc69ce

Please sign in to comment.