Skip to content

sanity prompt: dependency floors and version-number calls are WARN, not BLOCK - #31

Merged
jdwyah merged 1 commit into
mainfrom
sanity-prompt-warn-version-calls
Oct 11, 2026
Merged

jdwyah merged 1 commit into
mainfrom
sanity-prompt-warn-version-calls

Conversation

@jdwyah

@jdwyah jdwyah commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Prompt-only change (.github/claude-sanity-prompt.md), per Jeff's 2026-10-11 decision after openfeature-node#16 got a coin-flip BLOCK on a first-party peer-floor raise:

  • Raising a dependency / peer-dependency / engines / language-version floor, and choosing patch vs minor vs major, are WARN at most, never BLOCK.
  • House policy: raising the floor of a first-party Quonfig package within the same major ships as patch or minor; WARN only if the CHANGELOG does not mention it.
  • BLOCK stays for leaked secrets, a removed/renamed/incompatibly changed public export without a major bump, and clear production bugs.

The sanity job now reads the prompt from the base branch (quonfig/ci#10), so this PR is reviewed by the old prompt. No code or version change; nothing is published.

🤖 Generated with Claude Code

…ot BLOCK

Raising a dependency/peer/engines/language floor and choosing patch vs minor
vs major are judgment calls: WARN at most. First-party Quonfig floor raises
within a major ship as patch/minor. BLOCK stays for leaked secrets, removed or
renamed public API without a major bump, and clear production bugs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

SSDLC sanity check: WARN

Looking at the diff, this is a meta-PR that changes the sanity check criteria document itself.

Key changes:

  1. Lines 9-11: Removes "a raised minimum runtime/platform version" from the list of semver-breaking changes that require MAJOR version bumps
  2. Lines 22-33: Replaces simple blocking rules with new policy stating version/dependency floors are "judgment calls, reported as WARN at most, never BLOCK"

Finding:

WARN: Lines 10-11, 22-24 significantly relax version-bump policy by removing "raised minimum runtime/platform version" from automatic MAJOR-version-required breaking changes and reclassifying all version/dependency floors as WARN-level judgment calls (never BLOCK). This could permit breaking changes like "SDK now requires Ruby 3.2+" to ship in patch/minor releases, conflicting with semver. Needs documented rationale for this policy change and alignment confirmation with actual SDK versioning practice.


VERDICT: WARN

Model: claude-haiku-4-5-20251001, commit bd67d1d, prompt repo@96bc708. Only BLOCK fails this check. To override a BLOCK after reading it, a human adds ssdlc-approved (sanity check only, this commit only) or, in an emergency, hotfix (all checks, needs a justification and follow-up bead).

@jdwyah
jdwyah merged commit 578665f into main Oct 11, 2026
9 checks passed
@jdwyah
jdwyah deleted the sanity-prompt-warn-version-calls branch October 11, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant