Skip to content

HLLD solver does not compute flux for Eint #527

New issue
New issue
Open
Open
HLLD solver does not compute flux for Eint#527

Description

@BenWibking

BenWibking
openedon Feb 6, 2024

Describe the bug
The HLLD solver sets the flux for the auxiliary internal energy variable to zero:

quokka/src/HLLD.hpp

Line 329 in edc1dbc

// TODO(neco): Eint=0 for now; pscalars will also be needed in the future.

Within the Riemann solver, the auxiliary internal energy should be treated the same as a passive scalar.

Additional context
High-mach flows will not work correctly with MHD until this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    MHDbugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions