refactor: adopt svelte 5 for subsequent development #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve error logging on first build Add node api documentation links
In Svelte 3 and 4, components are classes. In Svelte 5 they are functions and should be instantiated differently.
…atcher` in svelte5
quoid
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Svelte 5 Release Candidate phase have arrived, and the ongoing UI refactoring involves a lot of Svelte code refactoring, we decided to adopt Svelte 5 preview in advance for subsequent development work.
There are no obvious issues in the current version build test, except for a few svelte/transition related errors. We just need to wait for the official resolution of related issues.