Improvement: TDengine sink adds empty value checking and supports string-formatted timestamps #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements and refactoring to the
TDengineSink
implementation, focusing on improved timestamp handling, stricter validation, and better error reporting.time_setter
parameter toTDengineSink
, which can accept a column name or a callable to determine the timestamp. It supportsint
,string
(RFC3339 format), ordatetime
values. AValueError
is raised if bothtime_key
andtime_setter
are set.ValueError
if these conditions are not met.time_setter
parameter and its behavior. Clarified the behavior oftime_key
and added notes about potential exceptions.