Skip to content

Conversation

huskar-t
Copy link
Contributor

This pull request introduces enhancements and refactoring to the TDengineSink implementation, focusing on improved timestamp handling, stricter validation, and better error reporting.

  • Added a new time_setter parameter to TDengineSink, which can accept a column name or a callable to determine the timestamp. It supports int, string (RFC3339 format), or datetime values. A ValueError is raised if both time_key and time_setter are set.
  • Added checks to ensure that supertable names are non-empty and fields are present. Raises ValueError if these conditions are not met.
  • Enhanced error reporting for overlapping keys between fields and tags, with detailed error messages.
  • Updated the documentation to reflect the new time_setter parameter and its behavior. Clarified the behavior of time_key and added notes about potential exceptions.

@huskar-t huskar-t marked this pull request as ready for review July 19, 2025 06:28
@huskar-t
Copy link
Contributor Author

huskar-t commented Aug 5, 2025

Added retry mechanism

tim-quix
tim-quix previously approved these changes Aug 6, 2025
@tim-quix
Copy link
Contributor

tim-quix commented Aug 6, 2025

Linters need to be run/applied. Might be easier to do ourselves post-merge?

@huskar-t
Copy link
Contributor Author

huskar-t commented Aug 7, 2025

Fixed the formatting issues.

@tim-quix tim-quix merged commit 03e6c09 into quixio:main Aug 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants