[quinn-udp] Support vectored sends. (WIP) #2178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial attempt for linux. Not sure what to do about generic/windows.
kixelated
requested review from
djc,
Ralith,
gretchenfrage and
mxinden
as code owners
kixelated
changed the title
kixelated
commented
Mar 19, 2025
| @@ -90,7 +90,7 @@ pub fn criterion_benchmark(c: &mut Criterion) { | |||
| send_state.send((&send_socket).into(), &transmit) | |||
| }) | |||
| .unwrap(); | |||
| sent += transmit.contents.len(); | |||
There was a problem hiding this comment.
This is why I renamed contents, otherwise it wouldn't be a breaking change.
| udp::Transmit { | ||
| destination: t.destination, | ||
| ecn: t.ecn.map(udp_ecn), | ||
| contents: buffer, |
There was a problem hiding this comment.
Errors with a reference to a temporary variable if you do:
buffers: &[IoSlice::new(buffer)],
kixelated
changed the title
|
This looks good to me overall.
I think Windows should look very similar to Unix here, with easy first-class support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt for linux. Not sure what to do about Windows.