Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Download" buttons with popup (including Open in "QuiltSync" button) #4353

Merged
merged 80 commits into from
Mar 17, 2025
Merged

"Download" buttons with popup (including Open in "QuiltSync" button) #4353

merged 80 commits into from
Mar 17, 2025

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Mar 10, 2025 •
edited
Loading

  • There is also unrelated customization of the StyledTooltip width in PR, because I used it but then opted to M.Paper with position: absolute
  • Removed containers/OpenInDesktop and re-purposed containers/Bucket/Download for download button and download/QuiltSync/code samplse popup
  • Simplified code samples, removed push section
1.get-package-edited.webm

2 get sub package
3 get package selected files
4 get package file

5.get.directory.1.webm

6 get file

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

fiskus added 30 commits March 6, 2025 15:44
@fiskus
open in desktop on package page
33e5de8
@fiskus
put code into tooltip in Bucket/File and Bucket/Dir and configure the…
1fe3708 
… StyledTooltip width
@fiskus
refactor: replace link with button group for desktop app dropdown menu
9d0eae8
@fiskus
refactor: move button inside tooltip and use ClickAwayListener for cl…
488b8c2 
…osing
@fiskus
adjust styles
cea5aae
@fiskus
refactor: replace M.Tabs with custom tab buttons and vertical divider
0defb91
@fiskus
simplify styles
1898be5
@fiskus
refactor: replace TextField with StyledLink in QuiltSync component
e148f0a
@fiskus
optimize
f1e6604
@fiskus
refactor: split Download component into DownloadFile and DownloadDir
2e8027e
@fiskus
polishing the UI
7ee8118
@fiskus
update the test spec
968cac9
@fiskus
reitrate on code and download button for Bucket view
3b75e2b
@fiskus
remove download component
e21c8fb
@fiskus
move download button to ./Download
bf791ee
@fiskus
optimize use of s3 handles
d49a1b8
@fiskus
re-organize files, remove OpenInDesktop, re-use Download
1186e3c
@fiskus
dummy file
90d7a32
@fiskus
refactor: extract common tab component to OptionsTabs
a3693ed
@fiskus
refactor: replace Tab interface with labels array and children render…
88952eb 
… prop
@fiskus
simplify
2a085e2
@fiskus
refactor: extract CodePanel and DownloadPanel components in bucket op…
a73eb53 
…tions
@fiskus
refactor: use classnames package for conditional class application in…
51f0b91 
… OptionsTabs
@fiskus
refactor: simplify tab rendering logic in download options components
6ef32e0
@fiskus
refactor: add TabPanel component and rename OptionsTabs to Tabs
a96056f
@fiskus
TabPanel component
3ba6232
@fiskus
feat: add hideDownload and hideCode options to BucketOptions and Pack…
7023a49 
…ageOptions
@fiskus
refactor: implement mutually exclusive hideCode and hideDownload options
016d39f
@fiskus
fix types and reorganize to beautify
5dcb999
@fiskus
refactor: implement FileHandle and DirHandle types with isFile type g…
a98c439 
…uard
nl0
nl0 reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome ui/ux feel, some code-related suggestions inline

fiskus and others added 13 commits March 13, 2025 14:05
@fiskus @nl0
Apply suggestions from code review
a458f22 
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
@fiskus
feat: add memoized LineOfCode component for syntax highlighting
f4bdf03
@fiskus
style: change tab highlight color from primary to secondary
c2f287f
@fiskus
refactor: hardcode tab labels inside Tabs component
df644fe
@fiskus
refactor: use string literal type for activeTab instead of number
da650c2
@fiskus
refactor: replace children prop with download and code props in Optio…
35a1331 
…nsTabs
@fiskus
chore: add debug logging to CodePanel component
6c3e944
@fiskus
refactor: wrap components in TabPanel for consistent UI structure
42b7c5e
@fiskus
re-use download panel
dce24b0
@fiskus
refactor: reuse DownloadPanel component in PackageOptions similar to …
0053a4d 
…BucketOptions
@fiskus
reuse tab names for classes
d0d495d
@fiskus
refactor: use TabType for TabsProps interface definition
8243f11
@fiskus
fix
1166396
@fiskus fiskus requested a review from nl0 March 13, 2025 16:06
nl0
nl0 previously approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. one tiny nitpick inline

@fiskus fiskus requested a review from nl0 March 14, 2025 15:01
@fiskus fiskus added this pull request to the merge queue Mar 17, 2025
Merged via the queue into master with commit 0bd8bed Mar 17, 2025
34 of 37 checks passed
@fiskus fiskus deleted the open-in-desktop-bucket branch March 17, 2025 11:44
@fiskus fiskus changed the title "Open in desktop"/"Download" buttons with popup "Download" buttons with popup (including Open in "QuiltSync" button) Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@nl0 nl0 nl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fiskus @drernie @nl0