added release.yaml GitHub workflow - #101
Conversation
|
@SamWilsn , @lightclient , I'd appreciate a review. PS. on the right sidebar, there isn't an option to assign reviewers. |
| uses: actions/checkout@v2 | ||
|
|
||
| # Moves the `nightly` tag to `HEAD` | ||
| - name: Move nightly tag |
There was a problem hiding this comment.
I've always understood that tags are supposed to be immutable. What's the advantage over a nightly branch, or a series of nightly-2022-05-05 tags?
There was a problem hiding this comment.
I don't see a particular reason for ETK. This workflow follows the process for Foundry. I think in this case keeping track of one nightly build would be enough.
@SamWilsn should we just make it so that it keeps track of only one nightly tag?
There was a problem hiding this comment.
So sorry for not replying sooner!
I'm strongly opposed to moving a tag. I'd much prefer a series of nightly-YYYY-MM-DD tags that never change, and possibly a nightly branch that points to the latest one.
That said, I'm not even sure there's much value in tagging nightlies? Considering how slowly we develop ETK, I think we could make do with publishing binaries only for numbered releases.
2 participants
This PR adds a
release.yamlworkflow to build nightly and tagged binaries.closes #100 .