Time-Aware Base Fee Calculation #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
reviewed
Oct 29, 2021
mkalinin
reviewed
Oct 29, 2021
| MAX_GAS_TARGET_PERCENT = 95 | ||
|
|
||
| class World(ABC): | ||
| def validate_block(self, block: Block) -> None: |
There was a problem hiding this comment.
I would suggest to be explicit about what exactly has been changed comparing to the original formula. Also, it would probably be clearer to have a function compute_parent_adjusted_gas_target and replace parent_gas_target in the original formula with parent_adjusted_gas_target = compute_parent_adjusted_gas_target(...)
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip
todo:
MAX_GAS_TARGET_PERCENTto rationale