Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to using TB for helpers #383

Merged
merged 2 commits into from
Oct 22, 2020
Merged

switched to using TB for helpers #383

merged 2 commits into from
Oct 22, 2020

Conversation

colezlaw
Copy link
Contributor

For helper functions, it's a good idea to accept a testing.TB which is an interface that *testing.T and *testing.B both satisfy, so you can call helper functions from a test, or a benchmark.

@quii
Copy link
Owner

quii commented Oct 22, 2020

Fantastic effort @colezlaw , nice one

@quii quii merged commit 4462875 into quii:main Oct 22, 2020
@colezlaw colezlaw deleted the usetb branch November 3, 2020 16:04
yuchen pushed a commit to go-proj/learn-go-with-tests that referenced this pull request Mar 5, 2021
Co-authored-by: Will Stranathan <will@cltnc.us>
Co-authored-by: Chris James <qui666@gmail.com>
gypsydave5 pushed a commit to gypsydave5/learn-go-with-tests that referenced this pull request Jun 11, 2021
Co-authored-by: Will Stranathan <will@cltnc.us>
Co-authored-by: Chris James <qui666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants