http-server: use strings.Trimspace instead of slicing #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Didn't know about that |
arkanjoms
pushed a commit
to arkanjoms/learn-go-with-tests
that referenced
this pull request
Nov 4, 2019
voelzmo
added a commit
to voelzmo/learn-go-with-tests
that referenced
this pull request
Jun 4, 2021
This was changed with quii#283 in the previous chapter. Following through with this change in the json chapter to stay consistent.
voelzmo
added a commit
to voelzmo/learn-go-with-tests
that referenced
this pull request
Jun 9, 2021
This was changed with quii#283 in the previous chapter. Following through with this change in the json chapter to stay consistent.
quii
pushed a commit
that referenced
this pull request
Jun 10, 2021
* Adapt player name extraction in json chapter This was changed with #283 in the previous chapter. Following through with this change in the json chapter to stay consistent. * Adapt player name extraction in io chapter * Adapt player name extraction in cmdline chapter * Adapt player name restriction in time chapter * Adapt player name extraction in websocket chapter
gypsydave5
pushed a commit
to gypsydave5/learn-go-with-tests
that referenced
this pull request
Jun 11, 2021
* Adapt player name extraction in json chapter This was changed with quii#283 in the previous chapter. Following through with this change in the json chapter to stay consistent. * Adapt player name extraction in io chapter * Adapt player name extraction in cmdline chapter * Adapt player name restriction in time chapter * Adapt player name extraction in websocket chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Change all instances of
player := r.URL.Path[len("/players/"):]toplayer := strings.TrimPrefix(r.URL.Path, "/players/")using
strings.Trimspacesimilarly to how the http package source code does it:https://golang.org/src/net/http/server.go?#L2040