feat(search): pin Foyer and add split-range disk cache config - #6700
Open
congx4 wants to merge 1 commit into
Open
feat(search): pin Foyer and add split-range disk cache config#6700congx4 wants to merge 1 commit into
congx4 wants to merge 1 commit into
Conversation
Pin Foyer 0.22.3 so the searcher can grow a process-wide disk cache for exact split ranges, and add the disabled-by-default config surface for it. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first slice of a Foyer disk cache for exact split footer and body ranges. Follow-up PRs will add the cache key codec, Foyer device, and searcher wiring.
Summary
0.22.3and mixtrics0.2.5, declare them onquickwit-storage, and regenerateLICENSE-3rdparty.csv.searcher.split_range_disk_cacheconfig (disabled by default).write_policydefaults towrite-on-evictionwhen omitted.Test plan
cargo check -p quickwit-storagecargo test -p quickwit-config split_range_disk_cachecargo clippy -p quickwit-config -p quickwit-storage --all-features --tests -- -D warningscargo +nightly fmt --all -- --checkMade with Cursor