Pin Python packages in workflows. See #5937 #5949
Draft
+287
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guilload could you please check this fix as well? |
|
This is going to be a bit of work to maintain each time we add or upgrade a dependency. Can we have CI use pipenv instead and rely on the same Pipfile / Pipfile.lock files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pin Python packages in GitHub workflows by hash to ensure reliable production builds.
Used
pip freezeto get a list of packages with exact version numbers and thenpip-compile --output-file=requirements.txt requirements.in --generate-hashesto get hashesHow was this PR tested?
n/a