Skip to content

Conversation

PSeitz
Copy link
Collaborator

@PSeitz PSeitz commented Jan 26, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@PSeitz PSeitz force-pushed the cat_indices branch 4 times, most recently from d475f9e to cbd28d9 Compare January 27, 2024 07:20
@PSeitz PSeitz requested a review from fmassot January 27, 2024 07:22
format!("Parameter {:?} is not supported.", field),
)
};
if self.bytes.is_some() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice checks

method: [GET]
engines:
- quickwit
endpoint: "_cat/indices/gharchive?format=json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test with a glob pattern?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I added a test

@PSeitz PSeitz merged commit 99a92dd into main Jan 30, 2024
@PSeitz PSeitz deleted the cat_indices branch January 30, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants