Skip to content

Conversation

fulmicoton
Copy link
Collaborator

Closes #3725

@fulmicoton fulmicoton force-pushed the issue/3725-multimatch-query branch from a1b6021 to 21fd0bd Compare August 9, 2023 07:59
@fulmicoton fulmicoton force-pushed the issue/3725-multimatch-query branch from 21fd0bd to 8e646e4 Compare August 9, 2023 08:01
@fulmicoton fulmicoton marked this pull request as ready for review August 9, 2023 08:04
@fulmicoton fulmicoton force-pushed the issue/3725-multimatch-query branch 3 times, most recently from b6fec2f to abce793 Compare August 9, 2023 08:21
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see per-field boosting and wildcard fields. I don't know if we want to support them, if we don't, we should probably return an explicit error when getting one of those

@fulmicoton fulmicoton force-pushed the issue/3725-multimatch-query branch from abce793 to 8e21610 Compare August 10, 2023 02:02
@fulmicoton
Copy link
Collaborator Author

per-field boosting and wildcard fields

I added code to return an error in that case.

@fulmicoton fulmicoton force-pushed the issue/3725-multimatch-query branch from 8e21610 to ad5504d Compare August 10, 2023 02:13
@fulmicoton fulmicoton force-pushed the issue/3725-multimatch-query branch from ad5504d to 8c95d17 Compare August 10, 2023 05:19
@fulmicoton fulmicoton merged commit f9f9114 into main Aug 11, 2023
@fulmicoton fulmicoton deleted the issue/3725-multimatch-query branch August 11, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ES multimatch query

2 participants