Skip to content

Conversation

Rexcrazy804
Copy link
Contributor

@Rexcrazy804 Rexcrazy804 commented Aug 10, 2025

  • seperated default.nix into two derrivations
  • default.nix hosting the wrapper and unwrapped.nix with original qs drv
  • passing non list argument to .withModules now displays an appropriate error message (separate pr?)
  • reflected these changes onto CI and devShell nix code to override the unwrapped drv accordingly

Motivation

with the former implementation we were unable to call .overrideAttrs to
override the attributes of the underlying UNWRAPPED derivation (say
adding a postPatch)

With the current implementation, we may simply do so by calling
.override { quickshell-unwrapped = <qs-unwrapped with .overrideAttrs>; }

Tests Done

  • wrapper builds without errors
  • changing wrapper with .withModules does not rebuild everything
  • underlying unwrapped derivation's attrs are overridable
  • passing non list values to throws an appropriate error message

@Rexcrazy804
Copy link
Contributor Author

time to fix CI nix code :woe:

@Rexcrazy804
Copy link
Contributor Author

@outfoxxed could you take a look at this and lemme know what you want changed

@Rexcrazy804
Copy link
Contributor Author

build failure due to nix being down

@Rexcrazy804 Rexcrazy804 force-pushed the overridable-qs-unwrapped branch from 3804ffb to fb72b47 Compare October 1, 2025 11:29
@Rexcrazy804
Copy link
Contributor Author

Rexcrazy804 commented Oct 1, 2025

rebased, no more changes to ci code

@Rexcrazy804 Rexcrazy804 force-pushed the overridable-qs-unwrapped branch from 1a8d220 to ab6c42d Compare October 1, 2025 11:46
@Rexcrazy804 Rexcrazy804 marked this pull request as ready for review October 1, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant