Run local tests with run-test262 #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Love this! |
saghul
approved these changes
Oct 10, 2024
Contributor
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
LGTM! How do you want to proceed? Land this and fix run-262 later so we can run the actual suite on Windows or the other way around?
Contributor
Author
|
I'll go ahead and land this because this whole exercise ultimately is so I can add an expect-fail test for #567 :-) |
The ulterior motive here is not that I want to increase CI times further but that I want to repurpose run-test262 for running our own tests.
We always run the test262 suite in new-style mode.
bnoordhuis
force-pushed
the
local-tests
branch
from
327a7c0 to
07cc40e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is #579.