Skip to content

Use INT32_MAX instead of inline value #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saghul merged 1 commit into from
Aug 13, 2024
Merged

Use INT32_MAX instead of inline value #480

saghul merged 1 commit into from
Aug 13, 2024

Conversation

@saghul
Copy link
Contributor

@saghul saghul commented Aug 13, 2024

No description provided.

@saghul saghul merged commit 5db156f into master Aug 13, 2024
@saghul saghul deleted the saghul-patch-3 branch August 13, 2024 10:56
@chqrlie
Copy link
Collaborator

chqrlie commented Aug 13, 2024

This patch is OK for me, I suppose we wrote 0x7fffffff instead of INT32_MAX to avoid mixing signed and unsigned arguments in a comparison. Note however that 0x7fffffff has type int too, so this was not a good reason :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saghul @chqrlie @bnoordhuis